1377937 - Fix VSCode tasks on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

In bug 1323308 I added support for build, run, test etc. tasks for Visual Studio Code. As promised, this bug is about making sure the tasks work on Windows as well. I will post my WIP in a second.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

Review commit: https://reviewboard.mozilla.org/r/154032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154032/

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8883073 [details]
Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154032/diff/1-2/

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8883073 [details]
Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154032/diff/2-3/

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I took the opportunity to add a 'mach clobber python' and a 'mach lint -wo' task. Clobbering, running, testing all work, but the linting tasks only work on macOS and Linux. I'll file a followup to fix that, because I think it needs some changes outside the VSCode configuration files.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8883073 [details]
Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

https://reviewboard.mozilla.org/r/154032/#review160436

::: .vscode/tasks.json:6
(Diff revision 3)
>  {
>      // See https://go.microsoft.com/fwlink/?LinkId=733558
>      // for the documentation about the tasks.json format
>      "version": "2.0.0",
> -    "command": "${workspaceRoot}/mach",
> +    "windows": {
> +      "command": "\"\\mozilla-build\\start-shell.bat mach\""

Does this assume mozilla-build is located in a root directory on the same volume? I suppose there's not a better way to do this :/

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Gregory Szorc [:gps] from comment #5)
> Does this assume mozilla-build is located in a root directory on the same
> volume? I suppose there's not a better way to do this :/

Yeah, I couldn't come up with something better.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8883073 [details]
Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154032/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c2dd082c159
Fix VSCode tasks on Windows (NPOTB, DONTBUILD). r=gps

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6c2dd082c159

Comment 10

[Jean-Yves Avenard [:jya]]

FWIW, this doesn't work for me.
Running the build task simply open a shell, and that's it. Nothing is ever built

this is what is showing in the output console:

> Executing task: "\mozilla-build\start-shell.bat mach" --log-no-times build <

MozillaBuild Install Directory: C:\mozilla-build\

jyavenard@jyaxps ~

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Did you modify terminal.integrated.shell.windows? It works on Windows 10 with the default PowerShell in my testing. If you have changed that pref to start start-shell.bat then it won't work. Please file a new bug if that is not the case and I'll try to figure it out.