Closed Bug 1377937 Opened 2 years ago Closed 2 years ago

Fix VSCode tasks on Windows

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file)

In bug 1323308 I added support for build, run, test etc. tasks for Visual Studio Code. As promised, this bug is about making sure the tasks work on Windows as well. I will post my WIP in a second.
I took the opportunity to add a 'mach clobber python' and a 'mach lint -wo' task. Clobbering, running, testing all work, but the linting tasks only work on macOS and Linux. I'll file a followup to fix that, because I think it needs some changes outside the VSCode configuration files.
Comment on attachment 8883073 [details]
Bug 1377937 - Fix VSCode tasks on Windows (NPOTB, DONTBUILD).

https://reviewboard.mozilla.org/r/154032/#review160436

::: .vscode/tasks.json:6
(Diff revision 3)
>  {
>      // See https://go.microsoft.com/fwlink/?LinkId=733558
>      // for the documentation about the tasks.json format
>      "version": "2.0.0",
> -    "command": "${workspaceRoot}/mach",
> +    "windows": {
> +      "command": "\"\\mozilla-build\\start-shell.bat mach\""

Does this assume mozilla-build is located in a root directory on the same volume? I suppose there's not a better way to do this :/
Attachment #8883073 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #5)
> Does this assume mozilla-build is located in a root directory on the same
> volume? I suppose there's not a better way to do this :/

Yeah, I couldn't come up with something better.
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c2dd082c159
Fix VSCode tasks on Windows (NPOTB, DONTBUILD). r=gps
https://hg.mozilla.org/mozilla-central/rev/6c2dd082c159
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
FWIW, this doesn't work for me.
Running the build task simply open a shell, and that's it. Nothing is ever built

this is what is showing in the output console:

> Executing task: "\mozilla-build\start-shell.bat mach" --log-no-times build <

MozillaBuild Install Directory: C:\mozilla-build\

jyavenard@jyaxps ~
Did you modify terminal.integrated.shell.windows? It works on Windows 10 with the default PowerShell in my testing. If you have changed that pref to start start-shell.bat then it won't work. Please file a new bug if that is not the case and I'll try to figure it out.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.