1377967 - Middle click on Bookmark and History closed tab entry does not open it in new tab

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Alice0775 White]

Reproducible : always

Steps To Reproduce:
1. Open Hamburger menu
2-1 Open Library > Bookmarks. And middle mouse click on a Bookmark entry.
2-2 Open Library > History. And middle mouse click on a closed tab entry.

Actual Results:
Nothing opened

Expected Results:
The entry should be open in new tab

Comment 1

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #0)
> Reproducible : always
> 
> Steps To Reproduce:
> 1. Open Hamburger menu
> 2-1 Open Library > Bookmarks. And middle mouse click on a Bookmark entry.

I can reproduce this. Note that modifier-click (ie ctrl/cmd) *does* work.

> 2-2 Open Library > History. And middle mouse click on a closed tab entry.

but not this. This breaking would be confusing anyway, because it's the same subview as we show for the history button. Can you reproduce this second bit on a clean profile? Anything else that might explain the difference? Can you maybe find a regression window, which might help narrow this down?

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs from comment #1)
> > 2-2 Open Library > History. And middle mouse click on a closed tab entry.
> 
> but not this.

Is it possible you're clicking a 'closed window' entry instead? I can reproduce that not doing anything with middle clicks, but that seems like it isn't a regression - I can reproduce on beta with the old history button.

Comment 3

[Alice0775 White]

> 2-2 Open Library > History. And middle mouse click on a closed tab entry.

Correct STR is as follows

2-2-0 Close 3 tabs for example
2-2-1 Open Library > History
2-2-2 Middle mouse click on a 1st closed tab entry.
      --- observe, it open in new tab as expected
      Middle mouse click on a 2nd closed tab entry.
      --- observe, It seems 3rd one opened in new tab --- BUG
      Middle mouse click on a 3rd closed tab entry.
      --- observe, nothing opened --- BUG


Actual Results:
1st one is properly open in newtab.
However, 2nd, 3rd and ...
Sometimes open wrong url in newtab
Sometimes not open anything

Expected Results:
Should open them in newtab properly

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Since the photon team triaged this I'm marking the bug fix-optional for 56. Happy to take a patch, but the platform team doesn't need to re-triage.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly,

Review commit: https://reviewboard.mozilla.org/r/166702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166702/

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8895508 [details]
Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly,

https://reviewboard.mozilla.org/r/166702/#review172260

Nice!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d1389a96ca
make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out so bug 1388753 could be backed out: https://hg.mozilla.org/integration/autoland/rev/f5c973874a8cc631cf06f3edaf38c8a363398b81

Comment 9

[:Gijs (he/him)]

Comment on attachment 8895508 [details]
Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166702/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6a9fbaf06ad
make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer

Comment 11

[:Gijs (he/him)]

Re-landed after relanding the other bug without the test change.

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/2948b2ab68a1
Backed out changeset e4d1389a96ca because it blocks the backout of bug 1388753. r=backout

Comment 13

[:Gijs (he/him)]

Comment on attachment 8895508 [details]
Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166702/diff/2-3/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e5d83fadfa
make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/64f5e3f40f0e
make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer a=reland stuff lost during last merge

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a6a9fbaf06ad

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/64f5e3f40f0e

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/52e5d83fadfa

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 20

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)
> Please request Beta approval on this when you get a chance.

Why? Beta isn't affected, is it? It doesn't have a library button, and AIUI everything else works correctly there.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Bah, missed the Photon part :)

Comment 22

[u554753]

Verified on Windows, Mac, and Ubuntu.