1377983 - Remove comparative V2/V4 Application Reputation telemetry probes

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[François Marier [:francois]]

We should remove these probes since we are no longer running V2 and V4 in parallel on Nightly:

- APPLICATION_REPUTATION_ALLOWLIST_MATCH
- APPLICATION_REPUTATION_BLOCKLIST_MATCH

The code using these probes was removed in bug 1366965 so all that's left is to take this out of Histograms.json.

Comment 1

[François Marier [:francois]]

Thomas, are you able to prepare a quick patch for this?

I'd do it myself but then I won't be able to review it :)

Comment 2

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1377983 - Remove comparative V2/V4 Application Reputation telemetry probes

Review commit: https://reviewboard.mozilla.org/r/154086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154086/

Comment 3

[Thomas Nguyen (:tnguyen)]

sure, I checked blame and they are mistakenly added in bug 1297167. Removed them.

Comment 4

[François Marier [:francois]]

Comment on attachment 8883149 [details]
Bug 1377983 - Remove comparative V2/V4 Application Reputation telemetry probes

https://reviewboard.mozilla.org/r/154086/#review159216

r+ and datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a03457de72b
Remove comparative V2/V4 Application Reputation telemetry probes r=francois

Comment 6

[François Marier [:francois]]

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #3)
> sure, I checked blame and they are mistakenly added in bug 1297167. Removed
> them.

Ah, that's why the blame was so weird. Nice investigation :)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a03457de72b