1378005 - stylo: Eliminate the teardown traversal

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Bobby Holley (:bholley)]

Now that bug 1377010 landed, we can avoid traversing the entire tree when tearing down the presshell. This should save us some millseconds during document teardown.

I've got patches that I need to run through try.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=080057dee6846a3a03e6d05018884b5e9430df89

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03154f377ea13f2933bcd6856fc461b761d27954&selectedJob=111745274

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Use GC machinery rather than recursion for post-rule-tree-teardown node dropping. v1

MozReview-Commit-ID: BPC6u4sBNPR

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Detect prescontext re-initialization and drop any servo data that exists. v1

MozReview-Commit-ID: 76dmk3ip3hv

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 3 - Stop synchronously clearing serving data on style set teardown. v1

MozReview-Commit-ID: 3B2qV84peCv

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8883353 [details] [diff] [review]
Part 1 - Use GC machinery rather than recursion for post-rule-tree-teardown node dropping. v1

Review of attachment 8883353 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, that's somewhat nasty... Looks fine. r=me

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8883354 [details] [diff] [review]
Part 2 - Detect prescontext re-initialization and drop any servo data that exists. v1

Review of attachment 8883354 [details] [diff] [review]:
-----------------------------------------------------------------

Do we need to go through all the style roots? (Can there be any other than the root at that point?)

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8883355 [details] [diff] [review]
Part 3 - Stop synchronously clearing serving data on style set teardown. v1

Review of attachment 8883355 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. There's a typo in the commit message, also (s/serving/Servo/, I assume).

Comment 9

[Bobby Holley (:bholley)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #7)
> Comment on attachment 8883354 [details] [diff] [review]
> Part 2 - Detect prescontext re-initialization and drop any servo data that
> exists. v1
> 
> Review of attachment 8883354 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Do we need to go through all the style roots? (Can there be any other than
> the root at that point?)

I think we don't need to - the other ones are all NAC, which is gone of the frame tree is gone.

Thanks for the fast reviews!

Comment 10

[Bobby Holley (:bholley)]

https://github.com/servo/servo/pull/17602

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28ce699eb74c
Detect prescontext re-initialization and drop any servo data that exists. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2abf534b2d0c
Stop synchronously clearing serving data on style set teardown. r=emilio

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/28ce699eb74c
https://hg.mozilla.org/mozilla-central/rev/2abf534b2d0c