1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp)

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp).

Review commit: https://reviewboard.mozilla.org/r/157718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157718/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8886953 [details]
Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp).

https://reviewboard.mozilla.org/r/157718/#review163134

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 716887915f3f -d 7d0caa2e93d7: rebasing 407639:716887915f3f "Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup" (tip)
merging dom/media/CubebUtils.cpp
merging dom/media/GraphDriver.cpp
merging dom/media/webaudio/BiquadFilterNode.cpp
merging dom/media/webaudio/IIRFilterNode.cpp
warning: conflicts while merging dom/media/GraphDriver.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc016256eba
Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4da0547ae82c
Backed out changeset 6dc016256eba for bustage at dom/media/webaudio/WebAudioUtils.cpp:107. r=backout on a CLOSED TREE

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage at dom/media/webaudio/WebAudioUtils.cpp:107:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4da0547ae82c8b271bb38a9658e6ff25d186e870

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6dc016256eba8c18f99ba2b3591239df27441846&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=115157101&repo=mozilla-inbound

> /home/worker/workspace/build/src/dom/media/webaudio/WebAudioUtils.cpp:107:25: error: Refcounted variable 'aMainThread' of type 'mozilla::AbstractThread' cannot be captured by a lambda

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38615ea10314
Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38615ea10314