Closed Bug 1378130 Opened 2 years ago Closed 2 years ago

fatal error: "assert(edge->fPrev->fPrev == nullptr || edge->fPrev->fX <= edge->fX)"

Categories

(Core :: Graphics, defect, P3)

55 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fixed

People

(Reporter: cbook, Assigned: lsalzman)

References

(Blocks 1 open bug, )

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Attachments

(2 files, 1 obsolete file)

Attached file bughunter stack
found via bughunter and reproduced on latest m-c tinderbox trunk debug build on latest ubuntu 

Steps to reproduce:
-> Load https://www.collegesearch.in/colleges/national-institute-of-construction-management-and-research-nicmar-pune#alumni
--> after some crazy redirects the debug build crash after 15-30 seconds 


home/worker/workspace/build/src/gfx/skia/skia/src/core/SkScan_AAAPath.cpp:1306: fatal error: "assert(edge->fPrev->fPrev == nullptr || edge->fPrev->fX <= edge->fX)"
Abort from sk_abort
Hit MOZ_CRASH() at /home/worker/workspace/build/src/memory/mozalloc/mozalloc_abort.cpp:33
Lee: could you take a look thanks!
Flags: needinfo?(lsalzman)
Whiteboard: [gfx-noted]
Upstream Skia bug report: https://bugs.chromium.org/p/skia/issues/detail?id=6947
Flags: needinfo?(lsalzman)
Just a straight backport of upstream fix here: https://skia-review.googlesource.com/c/33420
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Attachment #8896408 - Flags: review?(jmuizelaar)
Needed to add some small amount of extra fuzz to two tests where some AA pixels changed by 1 unit or so.
Attachment #8896408 - Attachment is obsolete: true
Attachment #8896408 - Flags: review?(jmuizelaar)
Attachment #8896811 - Flags: review?(jmuizelaar)
Attachment #8896811 - Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0249586bdc1
backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47b298a10edc
backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
Adjusted fuzz.
Flags: needinfo?(lsalzman)
https://hg.mozilla.org/mozilla-central/rev/47b298a10edc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is there a user impact here that justifies backport to Beta or can this ride the 57 train?
Blocks: 1340627
Flags: needinfo?(lsalzman)
Version: unspecified → 55 Branch
This does not seem to cause an observable issue outside of debug builds, so I am inclined to just let it ride the trains.
Flags: needinfo?(lsalzman)
You need to log in before you can comment on or make changes to this bug.