Closed
Bug 1378130
Opened 7 years ago
Closed 7 years ago
fatal error: "assert(edge->fPrev->fPrev == nullptr || edge->fPrev->fX <= edge->fX)"
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | wontfix |
firefox56 | --- | wontfix |
firefox57 | --- | fixed |
People
(Reporter: cbook, Assigned: lsalzman)
References
()
Details
(Keywords: crash, Whiteboard: [gfx-noted])
Attachments
(2 files, 1 obsolete file)
151.07 KB,
text/plain
|
Details | |
4.47 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
found via bughunter and reproduced on latest m-c tinderbox trunk debug build on latest ubuntu Steps to reproduce: -> Load https://www.collegesearch.in/colleges/national-institute-of-construction-management-and-research-nicmar-pune#alumni --> after some crazy redirects the debug build crash after 15-30 seconds home/worker/workspace/build/src/gfx/skia/skia/src/core/SkScan_AAAPath.cpp:1306: fatal error: "assert(edge->fPrev->fPrev == nullptr || edge->fPrev->fX <= edge->fX)" Abort from sk_abort Hit MOZ_CRASH() at /home/worker/workspace/build/src/memory/mozalloc/mozalloc_abort.cpp:33
Updated•7 years ago
|
Whiteboard: [gfx-noted]
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•7 years ago
|
||
Upstream Skia bug report: https://bugs.chromium.org/p/skia/issues/detail?id=6947
Flags: needinfo?(lsalzman)
Assignee | ||
Comment 3•7 years ago
|
||
Just a straight backport of upstream fix here: https://skia-review.googlesource.com/c/33420
Assignee | ||
Comment 4•7 years ago
|
||
Needed to add some small amount of extra fuzz to two tests where some AA pixels changed by 1 unit or so.
Attachment #8896408 -
Attachment is obsolete: true
Attachment #8896408 -
Flags: review?(jmuizelaar)
Attachment #8896811 -
Flags: review?(jmuizelaar)
Updated•7 years ago
|
Attachment #8896811 -
Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0249586bdc1 backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
I had to back this out for quantum render reftest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=123089464&repo=mozilla-inbound and https://treeherder.mozilla.org/logviewer.html#?job_id=123089457&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/8062a6549a1d8e2797dc85e3023c960110df5f75
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47b298a10edc backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
Reporter | ||
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/47b298a10edc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 10•7 years ago
|
||
Is there a user impact here that justifies backport to Beta or can this ride the 57 train?
Blocks: 1340627
status-firefox55:
--- → wontfix
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
Flags: needinfo?(lsalzman)
Version: unspecified → 55 Branch
Assignee | ||
Comment 11•7 years ago
|
||
This does not seem to cause an observable issue outside of debug builds, so I am inclined to just let it ride the trains.
Flags: needinfo?(lsalzman)
Updated•7 years ago
|
Comment hidden (spam) |
Comment hidden (spam) |
You need to log in
before you can comment on or make changes to this bug.
Description
•