Closed
Bug 1378161
Opened 7 years ago
Closed 7 years ago
browser/base/content/test/general/browser_bookmark_popup.js permafails on cedar (presumably will perma-fails once 56 merges to beta)
Categories
(Firefox :: Address Bar, defect)
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=cedar&selectedJob=111728787 Several failures with messages like this: 07:49:30 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred after closing - Got false, expected true 07:49:30 INFO - Stack trace: 07:49:30 INFO - chrome://mochikit/content/browser-test.js:test_is:967 07:49:30 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bookmark_popup.js:test_bookmarks_popup/<:69 07:49:31 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page should only be starred prior to popupshown if editing bookmark - Got false, expected true 07:49:31 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred - Got , expected true 07:49:31 INFO - Stack trace: 07:49:31 INFO - chrome://mochikit/content/browser-test.js:test_is:967 07:49:31 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_bookmark_popup.js:test_bookmarks_popup/<:52 I expect I made a mistake updating this test in bug 1352120.
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Marco Bonardo [::mak] from bug 1352120 comment #13) > Comment on attachment 8880009 [details] > Bug 1352120 - to fold: test changes, > > https://reviewboard.mozilla.org/r/151346/#review156760 > > ::: browser/base/content/test/general/browser_bookmark_popup.js:14 > (Diff revision 2) > > */ > > > > let bookmarkPanel = document.getElementById("editBookmarkPanel"); > > -let bookmarkStar = document.getElementById("bookmarks-menu-button"); > > +let bookmarkStar = AppConstants.MOZ_PHOTON_THEME ? > > + document.getElementById("star-button") : > > + document.getElementById("bookmarks-menu-button"); > > Maybe you could use the BookmarkingUI getters here (star or anchor?). The > test seems to use this just for the starred attribute and a click Of course, I should have checked this more carefully - BookmarkingUI.star and .anchor both return the inner elements for the pre-photon bookmarks-menu-button, and the 'starred' attribute is only set on the outer element, so now the test fails in non-photon.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8883397 [details] Bug 1378161 - update browser_bookmark_popup to correctly deal with the non-photon case, https://reviewboard.mozilla.org/r/154286/#review159532
Attachment #8883397 -
Flags: review?(mak77) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d3964f81fbd4 update browser_bookmark_popup to correctly deal with the non-photon case, r=mak
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d3964f81fbd4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•