1378194 - browser_ext_themes_icons.js permafails on cedar (presumably will perma-fails once 56 merges to beta)

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=cedar&revision=458bf72f6fa7a90e2f58d7778140c7a43f727e47&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=111730663&filter-classifiedState=unclassified


08:19:43     INFO - TEST-START | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js
08:19:43     INFO - TEST-INFO | started process screenshot
08:19:43     INFO - TEST-INFO | screenshot: exit 0
08:19:43     INFO - <snipped 65 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
08:19:43     INFO - Buffered messages logged at 08:19:43
08:19:43     INFO - Extension loaded
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6814 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6810 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6805 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6811 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6815 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6810 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6810 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6816 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6809 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6813 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6811 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6816 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6830 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6849 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6866 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6888 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6902 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6929 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6949 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6964 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6964 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 6964 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: Warning: attempting to write 16140 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
08:19:43     INFO - Console message: [JavaScript Error: "DataError: Data provided to an operation does not meet requirements."]
08:19:43     INFO - wrapMethods/cls.prototype[method]@resource://gre/modules/IndexedDB.jsm:103:47
08:19:43     INFO - get@resource://gre/modules/ExtensionParent.jsm:1358:22
08:19:43     INFO - async*parseManifest@resource://gre/modules/Extension.jsm:873:12
08:19:43     INFO - loadManifest@resource://gre/modules/Extension.jsm:543:7
08:19:43     INFO - async*loadManifest@resource://gre/modules/Extension.jsm:878:12
08:19:43     INFO - _startup@resource://gre/modules/Extension.jsm:1055:42
08:19:43     INFO - async*startup@resource://gre/modules/Extension.jsm:1031:27
08:19:43     INFO - _receiveMessageAPI/<@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:605:18
08:19:43     INFO - promise callback*_receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:590:9
08:19:43     INFO - ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:83:14
08:19:43     INFO - ChromePowers.prototype._sendAsyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:45:3
08:19:43     INFO - startup@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1980:9
08:19:43     INFO - runTestWithIcons@chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:167:9
08:19:43     INFO - async*test_all_icons@chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:234:9
08:19:43     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:763:21
08:19:43     INFO - TaskImpl_run@resource://gre/modules/Task.jsm:331:42
08:19:43     INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:408:7
08:19:43     INFO - TaskImpl_run@resource://gre/modules/Task.jsm:339:15
08:19:43     INFO - TaskImpl@resource://gre/modules/Task.jsm:280:3
08:19:43     INFO - asyncFunction@resource://gre/modules/Task.jsm:252:14
08:19:43     INFO - Task_spawn@resource://gre/modules/Task.jsm:166:12
08:19:43     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:758:9
08:19:43     INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:670:7
08:19:43     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
08:19:43     INFO - 
08:19:43     INFO - Console message: [JavaScript Warning: "Property contained reference to invalid variable.  Error in parsing value for ‘color’.  Falling back to ‘inherit’." {file: "chrome://browser/skin/browser.css" line: 204 column: 6353 source: " var(--titlebar-text-color)"}]
08:19:43     INFO - Console message: [JavaScript Warning: "Property contained reference to invalid variable.  Error in parsing value for ‘color’.  Falling back to ‘inherit’." {file: "chrome://browser/skin/browser.css" line: 204 column: 6353 source: " var(--titlebar-text-color)"}]
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #back-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #forward-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #reload-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #stop-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #downloads-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #home-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #PanelUI-menu-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #cut-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #copy-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #paste-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #new-window-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #privatebrowsing-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #save-page-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #print-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #history-panelmenu should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #fullscreen-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #find-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #preferences-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #add-ons-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #developer-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #sync-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #open-file-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #sidebar-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #social-share-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #feed-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #characterencoding-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #email-link-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #panic-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #pocket-button should have its icon customized in the toolbar - 
08:19:43     INFO - listStyleImage for fox.svg is url("moz-extension://ed67eb49-9228-4ebb-9c5b-2b76c813f495/fox.svg")
08:19:43     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | The #bookmarks-menu-button should have its icon customized in the toolbar - 
08:19:43     INFO - Buffered messages finished
08:19:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js | Unable to verify #bookmarks-menu-button > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon: TypeError: Argument 1 of Document.getAnonymousElementByAttribute is not an object. - 
08:19:43     INFO - Stack trace:
08:19:43     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:verifyButtonProperties:37
08:19:43     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:verifyButtonWithCustomStyling:62
08:19:43     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:checkButtons:79
08:19:43     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/test-oop-extensions/browser_ext_themes_icons.js:runTestWithIcons:169

Comment 1

[:Gijs (out for now; he/him)]

FWIW, I probably broke this in the second patch in bug 1352120.

Comment 2

[:Gijs (out for now; he/him)]

Attachment: Bug 1378194 - ordering of buttons in browser_ext_themes_icons.js matters; don't append bookmarks menu button at the end,

Review commit: https://reviewboard.mozilla.org/r/154308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154308/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8883408 [details]
Bug 1378194 - ordering of buttons in browser_ext_themes_icons.js matters; don't append bookmarks menu button at the end,

https://reviewboard.mozilla.org/r/154308/#review159606

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43acb10b33c0
ordering of buttons in browser_ext_themes_icons.js matters; don't append bookmarks menu button at the end, r=jaws

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43acb10b33c0

Comment 6

[Intermittent Failures Robot]

6 failures in 656 pushes (0.009 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* cedar: 6

Platform breakdown:
* windows7-32-vm: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1378194&startday=2017-07-03&endday=2017-07-09&tree=all