Closed
Bug 1378212
Opened 6 years ago
Closed 6 years ago
Ability to use latest parameters.yml file from given tree
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla56
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(2 files)
It's somewhat of a pain that users of ./mach taskgraph need to go and find a parameters.yml file to use. It would be great if we could specify something like: ./mach taskgraph target -p tree=mozilla-central This would find the latest decision task on that tree and automatically download + use its parameters.yml file. Making this process super easy will be a requirement if we want to use |mach taskgraph| to generate the list of tasks available to try.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
To re-iterate the commit message, I don't know how to test that first commit. It *looks* like it should work, but is mostly just a shot in the dark at this point.
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8883391 [details] Bug 1378212 - Give cron-based decision tasks unique index routes, https://reviewboard.mozilla.org/r/154272/#review159556 I think this is good. I'm not sure how to test it either :)
Attachment #8883391 -
Flags: review?(dustin) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8883392 [details] Bug 1378212 - Default to grabbing 'parameters.yml' file from latest mozilla-central decision task, https://reviewboard.mozilla.org/r/154274/#review159558 ::: taskcluster/taskgraph/parameters.py:78 (Diff revision 1) > except IOError: > - # fetching parameters.yml using task task-id or supplied url > + # fetching parameters.yml using task task-id, tree or supplied url > + task_id = None > if filename.startswith("task-id="): > task_id = filename.split("=")[1] > + elif filename.startswith("tree="): The taskgraph code is consistent in referring to this as a "project". It would be nice to continue that consistency (org-wide, it's known by a lot of names, of course)
Attachment #8883392 -
Flags: review?(dustin) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8883392 [details] Bug 1378212 - Default to grabbing 'parameters.yml' file from latest mozilla-central decision task, https://reviewboard.mozilla.org/r/154274/#review159580 ::: taskcluster/mach_commands.py:44 (Diff revision 2) > dest="format", const="json", > help="Output task graph as a JSON object"), > CommandArgument('--labels', '-L', action="store_const", > dest="format", const="labels", > help="Output the label for each task in the task graph (default)"), > - CommandArgument('--parameters', '-p', required=True, > + CommandArgument('--parameters', '-p', default="project=mozilla-central", ++
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d448af9b09e Give cron-based decision tasks unique index routes, r=dustin https://hg.mozilla.org/integration/autoland/rev/051408cf1c53 Default to grabbing 'parameters.yml' file from latest mozilla-central decision task, r=dustin
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d448af9b09e https://hg.mozilla.org/mozilla-central/rev/051408cf1c53
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 11•6 years ago
|
||
Thank you for implementing this feature. I just casually wrote a taskgraph patch and unlike previous times, I didn't have to worry about juggling a parameters.yml file: it just worked.
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•