Don't register visited callback if we have pending link update

RESOLVED FIXED in Firefox 56

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(3 attachments)

Don't know what tryserver thinks of this

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/939a561f5fd658c5ceffb52e25c4536f96a889ba
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=939a561f5fd658c5ceffb52e25c4536f96a889ba
Attachment #8883390 - Flags: review?(ehsan)
Attachment #8883390 - Flags: review?(ehsan) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb0c588a43e
Don't register visited callback if we have pending link update, r=ehsan
sanitizer... huh
Backout by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/af0466865a21
Backed out changeset 8eb0c588a43e for frequent win debug xpcshell failures in test_sanitizer.js a=backout
Aha, mozStorageService.cpp seems to have a bug.
yeah, it totally has bogus assumption.
Flags: needinfo?(bugs)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47021e6deb24
Don't register visited callback if we have pending link update, r=ehsan
oops, sorry, I shouldn't have landed that patch. backed it out.
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae2e674002d074b2d84fb1607a6cc7d7994b4f4
The issue in mozStorageService is that it assumes the service can't be instantiated after xpcom-shutdown. And since the patch in this bug makes us rely more on idle dispatch, we sure may do stuff later.
Attachment #8884044 - Flags: review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8cf0ecd184
Don't register visited callback if we have pending link update, r=ehsan,baku
https://hg.mozilla.org/mozilla-central/rev/3b8cf0ecd184
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.