Created attachment 8883390 [details] [diff] [review] link_update.diff Don't know what tryserver thinks of this remote: View your change here: remote: https://hg.mozilla.org/try/rev/939a561f5fd658c5ceffb52e25c4536f96a889ba remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=939a561f5fd658c5ceffb52e25c4536f96a889ba
Attachment #8883390 - Flags: review?(ehsan)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb0c588a43e Don't register visited callback if we have pending link update, r=ehsan
I had to back this out for being the apparent cause of frequent failures in test_sanitizer.js https://treeherder.mozilla.org/logviewer.html#?job_id=112061477&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/b7373e1df03eac30bca7b882a352a7282775059e
Backout by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/af0466865a21 Backed out changeset 8eb0c588a43e for frequent win debug xpcshell failures in test_sanitizer.js a=backout
Aha, mozStorageService.cpp seems to have a bug.
yeah, it totally has bogus assumption.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47021e6deb24 Don't register visited callback if we have pending link update, r=ehsan
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/35bdc75bcca9 back out the wrong patch, r=me
oops, sorry, I shouldn't have landed that patch. backed it out.
Created attachment 8884044 [details] [diff] [review] link_update_3.diff remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae2e674002d074b2d84fb1607a6cc7d7994b4f4
The issue in mozStorageService is that it assumes the service can't be instantiated after xpcom-shutdown. And since the patch in this bug makes us rely more on idle dispatch, we sure may do stuff later.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8cf0ecd184 Don't register visited callback if we have pending link update, r=ehsan,baku
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.