If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't register visited callback if we have pending link update

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 months ago
Created attachment 8883390 [details] [diff] [review]
link_update.diff

Don't know what tryserver thinks of this

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/939a561f5fd658c5ceffb52e25c4536f96a889ba
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=939a561f5fd658c5ceffb52e25c4536f96a889ba
Attachment #8883390 - Flags: review?(ehsan)
Attachment #8883390 - Flags: review?(ehsan) → review+

Comment 1

3 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb0c588a43e
Don't register visited callback if we have pending link update, r=ehsan

Comment 2

3 months ago
I had to back this out for being the apparent cause of frequent failures in test_sanitizer.js

https://treeherder.mozilla.org/logviewer.html#?job_id=112061477&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7373e1df03eac30bca7b882a352a7282775059e
Flags: needinfo?(bugs)
(Assignee)

Comment 3

3 months ago
sanitizer... huh

Comment 4

3 months ago
Backout by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/af0466865a21
Backed out changeset 8eb0c588a43e for frequent win debug xpcshell failures in test_sanitizer.js a=backout
(Assignee)

Comment 5

3 months ago
Aha, mozStorageService.cpp seems to have a bug.
(Assignee)

Comment 6

3 months ago
yeah, it totally has bogus assumption.
(Assignee)

Comment 7

3 months ago
Created attachment 8884040 [details] [diff] [review]
link_update_2.diff
Flags: needinfo?(bugs)

Comment 8

3 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47021e6deb24
Don't register visited callback if we have pending link update, r=ehsan

Comment 9

3 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35bdc75bcca9
back out the wrong patch, r=me
(Assignee)

Comment 10

3 months ago
oops, sorry, I shouldn't have landed that patch. backed it out.
(Assignee)

Comment 11

3 months ago
Created attachment 8884044 [details] [diff] [review]
link_update_3.diff

remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae2e674002d074b2d84fb1607a6cc7d7994b4f4
(Assignee)

Comment 12

3 months ago
The issue in mozStorageService is that it assumes the service can't be instantiated after xpcom-shutdown. And since the patch in this bug makes us rely more on idle dispatch, we sure may do stuff later.
Attachment #8884044 - Flags: review+

Comment 13

3 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8cf0ecd184
Don't register visited callback if we have pending link update, r=ehsan,baku

Comment 14

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b8cf0ecd184
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.