1378299 - Missing headers for MemoryBlockCache

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[C.M.Chang[:chunmin]]

When I try adding an idl file to dom/media, I saw some errors in MemoryBlockCache.cpp:

...
...
14:32.88 /Users/cchang/Work/gecko-mc/dom/media/MemoryBlockCache.cpp:30:12: error: expected class name
14:32.88   : public nsIObserver
14:32.88            ^
14:32.88 /Users/cchang/Work/gecko-mc/dom/media/MemoryBlockCache.cpp:31:12: error: expected class name
14:32.89   , public nsSupportsWeakReference
...
...
14:33.39 /Users/cchang/Work/gecko-mc/dom/media/MemoryBlockCache.cpp:76:14: error: use of undeclared identifier 'nsIObserverService'
...
0:05.91 /Users/cchang/Work/gecko-mc/dom/media/MemoryBlockCache.cpp:80:16: error: no member named 'services' in namespace 'mozilla'
 0:05.91       mozilla::services::GetObserverService();
 0:05.91       ~~~~~~~~~^

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1378299 - Fix the missing headers;

Review commit: https://reviewboard.mozilla.org/r/154390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154390/

Comment 2

[C.M.Chang[:chunmin]]

(In reply to Chun-Min Chang[:chunmin] from comment #0)
Fail messages on try-server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7784f8f0847daa6f9b2520e8ced9fbea61478677&selectedJob=111883267

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8883487 [details]
Bug 1378299 - Fix the missing headers;

https://reviewboard.mozilla.org/r/154390/#review159714

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Sorry for the troubles, and thank you for fixing it.

I wish there was an easy way to make non-unified builds, to catch these issues early.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daa4741d41e7
Fix the missing headers; r=cpearce

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/daa4741d41e7