Remove AbstractMediaDecoder::DataArrivedEvent()

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

7 months ago
Assignee: nobody → jwwang
Blocks: 1378295
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8883861 - Flags: review?(gsquelart)
Attachment #8883862 - Flags: review?(gsquelart)
Attachment #8883863 - Flags: review?(gsquelart)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8883861 [details]
Bug 1378316. P1 - store MediaDecoderReader in MediaDecoder.

https://reviewboard.mozilla.org/r/154824/#review160066

r+ with suggestion:

::: dom/media/fmp4/MP4Decoder.cpp:292
(Diff revision 1)
>  }
>  
>  void
>  MP4Decoder::GetMozDebugReaderData(nsACString& aString)
>  {
> -  if (mReader) {
> +  auto reader = static_cast<MediaFormatReader*>(mReader.get());

Downcasting is the one ugly thing about this changeset!

But fixing it (e.g., virtualizing GetMozDebugReaderData in MediaDecoderReader and MediaFormatReader) would probably be more work than is worth for a debugging function, so don't worry about it unless it's easy enough.

Maybe just add a comment with each downcast, to note that you "know it's a MediaFormatReader because ..."
Attachment #8883861 - Flags: review?(gsquelart) → review+

Comment 5

7 months ago
mozreview-review
Comment on attachment 8883862 [details]
Bug 1378316. P2 - dispatch MediaDecoderReader::NotifyDataArrived explicitly instead of using MediaEventSource.

https://reviewboard.mozilla.org/r/154826/#review160076
Attachment #8883862 - Flags: review?(gsquelart) → review+

Comment 6

7 months ago
mozreview-review
Comment on attachment 8883863 [details]
Bug 1378316. P3 - remove AbstractMediaDecoder::DataArrivedEvent() and related code.

https://reviewboard.mozilla.org/r/154828/#review160078
Attachment #8883863 - Flags: review?(gsquelart) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

7 months ago
Thanks for the review!

Comment 11

7 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a357ac5ab0f8
P1 - store MediaDecoderReader in MediaDecoder. r=gerald
https://hg.mozilla.org/integration/autoland/rev/4987a415f22d
P2 - dispatch MediaDecoderReader::NotifyDataArrived explicitly instead of using MediaEventSource. r=gerald
https://hg.mozilla.org/integration/autoland/rev/78ff4c023b6a
P3 - remove AbstractMediaDecoder::DataArrivedEvent() and related code. r=gerald

Comment 12

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a357ac5ab0f8
https://hg.mozilla.org/mozilla-central/rev/4987a415f22d
https://hg.mozilla.org/mozilla-central/rev/78ff4c023b6a
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.