Form Autofill Options/Preferences in the dropdown menu is too large

RESOLVED WONTFIX

Status

()

Toolkit
Form Manager
--
minor
RESOLVED WONTFIX
5 months ago
3 months ago

People

(Reporter: AdrianSV, Assigned: ralin)

Tracking

(Blocks: 1 bug)

56 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [form autofill])

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Created attachment 8883547 [details]
form_preferences.png

[Environment:]
Windows 10x64, Ubuntu 16.04, Mac Osx 10.12

Nightly 56.0a1 20170704100254

[Description:]
The size of the form autofill preferences (mac)/options(windows/ubuntu) should look as described in the specs: https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/188574112 

[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill. (default in Nightly)
Make sure you have at least one saved profile.


1.Open Firefox.
2.Navigate to Amazon.com and login with a valid account.
3.From the right corner hover Account &Lists and select account.
4.Click On Addresses button.
5.Click on Add Address.
6.Double click On Full name.


[Actual Result:]
The Form autofill options/preferences selection in the autofill drop-down menu is too large. (see screenshot)


[Expected Result:]
In my opinion the original spec version for the autofill options/preferences looks better. (https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/188574112)
Whiteboard: [form autofill]

Comment 1

4 months ago
Firefox footer size has been always 40px height, as for the design consistency, we need to keep it that way.
(Assignee)

Comment 2

4 months ago
Created attachment 8892275 [details]
inspector-computed-size.png

Thank you Fang, after your clarification, it looks like we got a slight change on height by 1px. I'll attach a quick fix to that.
Assignee: nobody → ralin
(Assignee)

Comment 3

4 months ago
Since this seems imperceptible for the 1px difference, I'm not hurriedly getting into the fix. Adrian, could you help me to verify the footer is around 40px height? It occurred to me that the height might slightly varies by ~1px, depending on the system font, so I think 40~41px is fine. Thank you :D
Flags: needinfo?(adrian.florinescu)
(Assignee)

Comment 4

4 months ago
the visual spec mentioned in comment 1: https://mozilla.invisionapp.com/share/MQ8J8K4CE#/screens/243501866, thanks
Marking as wontfix for now as I agree with above but feel free to reopen if Ray and Fang's comments aren't addressing the issue.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WONTFIX
(Reporter)

Updated

3 months ago
Flags: needinfo?(adrian.florinescu)
You need to log in before you can comment on or make changes to this bug.