1378356 - Don't throttle pages with active network connections

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, enhancement, P1)

Comment 1

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1378356-Don-t-throttle-pages-with-active-network.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0285b0e39d731541ef5c89a87d6e2f6408c1853d

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I need to still understand why we don't want to throttle pages with active network connections.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Since for throttling, why does it matter whether there are network connections open?
I do understand we need that for freezing a tab, but throttling isn't freezing.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

And this means we end up throttling less than what we have done for years.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8883875 [details] [diff] [review]
0001-Bug-1378356-Don-t-throttle-pages-with-active-network.patch

Since I don't understand the reasoning, can't really review.

Comment 6

[Andreas Farre [:farre]]

(In reply to Olli Pettay [:smaug] from comment #3)
> Since for throttling, why does it matter whether there are network
> connections open?
> I do understand we need that for freezing a tab, but throttling isn't
> freezing.

This is a valid point, maybe this isn't the right thing to do. Especially since we're only throttling timeouts and not all events. It should allow us to be more aggressive.

Comment 7

[Andrew Overholt [:overholt]]

(P1 but discussion here obviously trumps that)

Comment 8

[Andreas Farre [:farre]]

This is not the right thing to do. Non-WebSockets network connections should be handled by handlers in any case.