Closed
Bug 1378356
Opened 7 years ago
Closed 7 years ago
Don't throttle pages with active network connections
Categories
(Core :: DOM: Core & HTML, enhancement, P1)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: farre, Assigned: farre)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0285b0e39d731541ef5c89a87d6e2f6408c1853d
Attachment #8883875 -
Flags: review?(bugs)
Comment 2•7 years ago
|
||
I need to still understand why we don't want to throttle pages with active network connections.
Comment 3•7 years ago
|
||
Since for throttling, why does it matter whether there are network connections open? I do understand we need that for freezing a tab, but throttling isn't freezing.
Comment 4•7 years ago
|
||
And this means we end up throttling less than what we have done for years.
Comment 5•7 years ago
|
||
Comment on attachment 8883875 [details] [diff] [review] 0001-Bug-1378356-Don-t-throttle-pages-with-active-network.patch Since I don't understand the reasoning, can't really review.
Attachment #8883875 -
Flags: review?(bugs)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #3) > Since for throttling, why does it matter whether there are network > connections open? > I do understand we need that for freezing a tab, but throttling isn't > freezing. This is a valid point, maybe this isn't the right thing to do. Especially since we're only throttling timeouts and not all events. It should allow us to be more aggressive.
Updated•7 years ago
|
Assignee: nobody → afarre
Priority: -- → P1
Comment 7•7 years ago
|
||
(P1 but discussion here obviously trumps that)
Assignee | ||
Comment 8•7 years ago
|
||
This is not the right thing to do. Non-WebSockets network connections should be handled by handlers in any case.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•