137836 - When active tab is closed, "beforeselected" attribute remains on previous tab

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Brian Ryner (not reading)]

Steps to reproduce:

- Open a few tabs in the browser window
- Switch to the last tab
- Close the last tab

Result:

The formerly next-to-last tab becomes active, but still has the "beforeselected"
attribute set on it.  This can interfere with nsITheme-based drawing and
possibly match incorrect style rules.

Comment 1

[Tuukka Tolvanen (sp3000)]

Oh, that's why my last tab mostly never has the right-side border in Classic :)

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

This makes sure to clean up the attribute state before the tab is removed.

Comment 3

[jag (Peter Annema)]

Comment on attachment 79572 [details] [diff] [review]
patch

sr=jag

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 79572 [details] [diff] [review]
patch

r=[e-mail]

Comment 5

[Brian Ryner (not reading)]

nominating for beta... this causes an ugly visual defect in the classic skin
where after you close the last tab, the new last tab will no longer draw the
right-side border of the tab.

Comment 6

[Tuukka Tolvanen (sp3000)]

Well, not only last tab to be exact, any current tab except the first.

Comment 7

[Brian Ryner (not reading)]

This has been checked into the trunk, keeping bug open for nsbeta1 consideration.

Comment 8

[[e-mail]]

Comment on attachment 79572 [details] [diff] [review]
patch

Um... what was wrong with oldTab.selected = false; ?
See bug 102110 of which this is a duplicate.

Comment 9

[Samir Gehani]

Nav triage team: nsbeta1+, adt2 rtm

Comment 10

[Brian Ryner (not reading)]

*** Bug 102110 has been marked as a duplicate of this bug. ***

Comment 11

[Brian Ryner (not reading)]

Right on both counts.  I looked for a dup but this one wasn't apparent from the
summary; and what you suggest is indeed cleaner.  Follow-up patch coming up.

Comment 12

[Brian Ryner (not reading)]

Attachment: cleanup per neil's suggestion

Comment 13

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 80872 [details] [diff] [review]
cleanup per neil's suggestion

r=pink

Comment 14

[Blake Ross]

Comment on attachment 80872 [details] [diff] [review]
cleanup per neil's suggestion

sr=blake

Comment 15

[[e-mail]]

Bug 102110 probably wasn't specifc enough to match your query.

Comment 16

[Brian Ryner (not reading)]

Checked into the trunk.  Thanks Neil!

Comment 17

[Andreas Kunz]

Isn't this fix going into the branch?
You know it causes (or is) bug 116394, which is about the missing borders of 
tabs after closing others...

Comment 18

[Joonas]

Nominating for mozilla1.0 (simple fix, fixes an ugly visual defect)

Comment 19

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers' approval.  After, checking in, please add the fixed1.0 keyword.

Comment 20

[Scott Collins]

Comment on attachment 80872 [details] [diff] [review]
cleanup per neil's suggestion

a=scc (on behalf of drivers) for checkin to the mozilla1.0 branch; please get
it in asap

Comment 21

[Brian Ryner (not reading)]

checked in on the branch.

Comment 22

[shrirang khanzode]

 verif fixd 0812 brnch/trunk.