1378402 - Add budget throttling tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Andreas Farre [:farre]]

Even though unit testing for budget throttling is hard, it should be entirely possible to add tests that at least tests that no throttling happens in the cases where we dis-allow throttling, like when we have websockets, audio etc.

Comment 1

[Andrew Overholt [:overholt]]

Andreas is working on this.

Comment 2

[Andrew Overholt [:overholt]]

AFAIK these aren't destined to be fixed in 56 or 57 so I'm setting the priority to P2.

Comment 3

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78debee26ba6523fe29584e177d61b8c40117430

Comment 4

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f32d96ad00df90bb9d3464daa986e4378ffa0447&group_state=expanded

Comment 5

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1378402-Add-tests-for-budget-throttling.-r-bkell.patch

These are web platform tests located in the mozilla directory, which means that they're gecko only.

The tests will only run for non-debug builds, since they're prone to be intermittent, due to timeouts not running predictably enough. I'm hoping that they won't cause trouble, that's why I want to land them, but they're easily disabled by being isolated in their own directory if they do.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/448fa9629f60
Add tests for budget throttling. r=bkelly

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/448fa9629f60