1378412 - Build error on Linux 32 bit due to a warning in task_queue_libevent.cc with clang 4.0

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[(no longer active)]

mozconfig:
export CC=clang
export CXX=clang++
export CCACHE_COMPRESS=""
export CCACHE_CPP2="yes"
export CFLAGS="-fcolor-diagnostics"
export CXXFLAGS="-fcolor-diagnostics"

. $topsrcdir/browser/config/mozconfig
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-ff-opt32
mk_add_options AUTOCLOBBER=1

ac_add_options --enable-optimize
ac_add_options --disable-debug
ac_add_options --enable-profiling

error:
20:17.87 /moz/src.1347035/media/webrtc/trunk/webrtc/base/task_queue_libevent.cc:237:19: error: non-constant-expression cannot be narrowed from type 'unsigned int' to '__time_t' (aka 'long') in initializer list [-Wc++11-narrowing]
20:17.87     timeval tv = {milliseconds / 1000,
20:17.87                   ^~~~~~~~~~~~~~~~~~~
20:17.87 /moz/src.1347035/media/webrtc/trunk/webrtc/base/task_queue_libevent.cc:237:19: note: insert an explicit cast to silence this issue
20:17.87     timeval tv = {milliseconds / 1000,
20:17.87                   ^~~~~~~~~~~~~~~~~~~
20:17.87                   static_cast<__time_t>( )

Comment 2

[Dan Minor [:dminor]]

Attachment: Fix warning

Fixes the warning as the compiler suggests.

Comment 3

[(no longer active)]

You probably want to cast to time_t, not __time_t (the latter is an internal compiler specific typedef AFAIK.  Also note that this is upstream code AFAIK which we may not be allowed to modify locally.

Comment 4

[Dan Minor [:dminor]]

Attachment: Fix warning

Thanks for pointing out I had used __time_t.

We have already had to add a cast in the following line over in Bug 1375238 to fix another clang warning, so there's a precedent for fixing these.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b3851740c1b
Fix build error on Linux 32 bit due to a warning in task_queue_libevent.cc with clang 4.0; r=jesup

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b3851740c1b