Closed
Bug 1378481
Opened 7 years ago
Closed 7 years ago
warning: 'roundingError' may be used uninitialized in this function
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
[task 2017-07-05T14:42:51.050243Z] 14:42:51 INFO - /home/worker/workspace/build/src/layout/generic/nsGridContainerFrame.cpp:4758:25: warning: 'roundingError' may be used uninitialized in this function [-Wmaybe-uninitialized] [task 2017-07-05T14:42:51.051016Z] 14:42:51 INFO - roundingError -= 1; [task 2017-07-05T14:42:51.051529Z] 14:42:51 INFO - I'm guessing it's b/c the 'default' switch branch doesn't assign it. http://searchfox.org/mozilla-central/rev/e8f4f51cd543f203e9cb861cecb7545ac43c836c/layout/generic/nsGridContainerFrame.cpp#4758
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8883675 -
Flags: review?(dholbert)
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8648cd5683af Assign 'roundingError' in the default branch too, to avoid a maybe-uninitialized compiler warning. r=dholbert
|
||
Comment 3•7 years ago
|
||
retroactive r=me ;) This seems harmless, assuming it fixes the warning.
|
|
||
Updated•7 years ago
|
Attachment #8883675 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Oops, sorry. I misread my bugmail and thought the r+ in bug 1377490 was for this bug!
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8648cd5683af
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•