Closed Bug 1378484 Opened 3 years ago Closed 3 years ago

label net::WrappedChannelEvent

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: froydnj, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This runnable is in the top 20 or so runnables showing up from telemetry.
Assignee: nobody → kechang
Whiteboard: [necko-active]
net::WrappedChannelEvent is actually dispatched by BaseWebSocketChannel::mTargetThread which is assigned via BaseWebSocketChannel::RetargetDeliveryTo at [1].
Hence, the component of this bug should be DOM, rather than Networking.

[1] http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/dom/base/WebSocket.cpp#1870
Component: Networking: WebSockets → DOM
Whiteboard: [necko-active]
Please take a look. Thanks.
Attachment #8883848 - Flags: review?(amarchesini)
Comment on attachment 8883848 [details] [diff] [review]
Dispatch runnables to labeled event targt in WebSocket

Review of attachment 8883848 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WebSocket.cpp
@@ +2851,5 @@
>  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
>  {
>    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> +  // If the target is the main-thread, we should try to dispatch the runnable
> +  // to a labeled event taret.

target
Attachment #8883848 - Flags: review?(amarchesini) → review+
(In reply to Andrea Marchesini [:baku] from comment #3)
> Comment on attachment 8883848 [details] [diff] [review]
> Dispatch runnables to labeled event targt in WebSocket
> 
> Review of attachment 8883848 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/base/WebSocket.cpp
> @@ +2851,5 @@
> >  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
> >  {
> >    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> > +  // If the target is the main-thread, we should try to dispatch the runnable
> > +  // to a labeled event taret.
> 
> target

Thanks for the review.
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74d18a0b781
Dispatch runnables to labeled event target in WebSocket, r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d74d18a0b781
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.