label net::WrappedChannelEvent

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: froydnj, Assigned: kershaw)

Tracking

(Blocks: 1 bug)

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 months ago
This runnable is in the top 20 or so runnables showing up from telemetry.
Assignee: nobody → kechang
Whiteboard: [necko-active]
(Assignee)

Comment 1

4 months ago
net::WrappedChannelEvent is actually dispatched by BaseWebSocketChannel::mTargetThread which is assigned via BaseWebSocketChannel::RetargetDeliveryTo at [1].
Hence, the component of this bug should be DOM, rather than Networking.

[1] http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/dom/base/WebSocket.cpp#1870
Component: Networking: WebSockets → DOM
Whiteboard: [necko-active]
(Assignee)

Comment 2

4 months ago
Created attachment 8883848 [details] [diff] [review]
Dispatch runnables to labeled event targt in WebSocket

Please take a look. Thanks.
Attachment #8883848 - Flags: review?(amarchesini)
Comment on attachment 8883848 [details] [diff] [review]
Dispatch runnables to labeled event targt in WebSocket

Review of attachment 8883848 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WebSocket.cpp
@@ +2851,5 @@
>  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
>  {
>    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> +  // If the target is the main-thread, we should try to dispatch the runnable
> +  // to a labeled event taret.

target
Attachment #8883848 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 4

4 months ago
(In reply to Andrea Marchesini [:baku] from comment #3)
> Comment on attachment 8883848 [details] [diff] [review]
> Dispatch runnables to labeled event targt in WebSocket
> 
> Review of attachment 8883848 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/base/WebSocket.cpp
> @@ +2851,5 @@
> >  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
> >  {
> >    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> > +  // If the target is the main-thread, we should try to dispatch the runnable
> > +  // to a labeled event taret.
> 
> target

Thanks for the review.
(Assignee)

Comment 5

4 months ago
Created attachment 8884140 [details] [diff] [review]
Dispatch runnables to labeled event targt in WebSocket, r=baku

Carry r+.
Attachment #8883848 - Attachment is obsolete: true
Attachment #8884140 - Flags: review+
(Assignee)

Comment 6

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf0a4c227beba25e9ab7663bf205179bc1af8b5a
Keywords: checkin-needed

Comment 7

4 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74d18a0b781
Dispatch runnables to labeled event target in WebSocket, r=baku
Keywords: checkin-needed

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d74d18a0b781
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.