1378484 - label net::WrappedChannelEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Nathan Froyd [:froydnj]]

This runnable is in the top 20 or so runnables showing up from telemetry.

Comment 1

[Kershaw Chang [:kershaw]]

net::WrappedChannelEvent is actually dispatched by BaseWebSocketChannel::mTargetThread which is assigned via BaseWebSocketChannel::RetargetDeliveryTo at [1].
Hence, the component of this bug should be DOM, rather than Networking.

[1] http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/dom/base/WebSocket.cpp#1870

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Dispatch runnables to labeled event targt in WebSocket

Please take a look. Thanks.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8883848 [details] [diff] [review]
Dispatch runnables to labeled event targt in WebSocket

Review of attachment 8883848 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WebSocket.cpp
@@ +2851,5 @@
>  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
>  {
>    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> +  // If the target is the main-thread, we should try to dispatch the runnable
> +  // to a labeled event taret.

target

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Andrea Marchesini [:baku] from comment #3)
> Comment on attachment 8883848 [details] [diff] [review]
> Dispatch runnables to labeled event targt in WebSocket
> 
> Review of attachment 8883848 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/base/WebSocket.cpp
> @@ +2851,5 @@
> >  WebSocketImpl::Dispatch(already_AddRefed<nsIRunnable> aEvent, uint32_t aFlags)
> >  {
> >    nsCOMPtr<nsIRunnable> event_ref(aEvent);
> > +  // If the target is the main-thread, we should try to dispatch the runnable
> > +  // to a labeled event taret.
> 
> target

Thanks for the review.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Dispatch runnables to labeled event targt in WebSocket, r=baku

Carry r+.

Comment 6

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf0a4c227beba25e9ab7663bf205179bc1af8b5a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74d18a0b781
Dispatch runnables to labeled event target in WebSocket, r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d74d18a0b781