If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Missing #include in nsPrintDialogX.mm and nsCocoaWindow.mm

RESOLVED FIXED in Firefox 56

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: ewright, Assigned: ewright)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
Missing #include in `widget/cocoa/nsPrintDialogX.mm` and `widget/cocoa/nsCocoaWindow.mm`.
Apparently due to unified builds, some files have been forgotten.

#include "ScreenHelperCocoa.h"
and
#include "mozilla/Preferences.h"
(Assignee)

Updated

3 months ago
Assignee: nobody → ewright
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8883707 [details]
Bug 1378499 - add missing include files.

https://reviewboard.mozilla.org/r/154610/#review159700
Attachment #8883707 - Flags: review?(mstange) → review+
(Assignee)

Updated

3 months ago
Keywords: checkin-needed
Keywords: checkin-needed

Comment 3

3 months ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/c12c7198c4d3
add missing include files. r=mstange

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c12c7198c4d3
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.