No description provided.
Comment on attachment 8883787 [details] Bug 1378592 - Remove MOZ_REPLACE_MALLOC_LINKAGE. https://reviewboard.mozilla.org/r/154740/#review159980 I would love to have my confusion below cleared up somehow. ::: commit-message-508a3:13 (Diff revision 1) > +Keeping those around doesn't /really/ hurt, except recent versions of > +Xcode don't expose dyldinfo in /usr/bin, used for the configure test. I don't fully grok this claim. If all that matters is the configure test, we (seemingly) have all the info we need for this in the cross-compilation setup, right? So it doesn't really explain why nightlies were busted--though it's possible I'm missing something. Or were we getting the wrong answer because cross-compiles were returning the wrong thing? It would definitely affect people building locally, I guess, so it's good to get it fixed up one way or another. ::: old-configure.in (Diff revision 1) > -if test -n "$MOZ_REPLACE_MALLOC"; then > - dnl Replace-malloc Mac linkage quirks Getting rid of this much of old-configure.in in one shot is great.
Attachment #8883787 - Flags: review?(nfroyd) → review+
Automation builds weren't actually affected. They were using "compiler support" already: [task 2017-07-06T15:56:00.452885Z] 15:56:00 INFO - checking how to do weak dynamic linking... compiler support Note *this bug* does not address what busted nightlies, but bug 1378332, as mentioned in the commit message. What busted the nightlies is addressed in bug 1356701 itself.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/67324ef6c302 Remove MOZ_REPLACE_MALLOC_LINKAGE. r=froydnj
You need to log in before you can comment on or make changes to this bug.