1378617 - Crash in java.lang.ClassCastException: android.graphics.drawable.VectorDrawable cannot be cast to android.graphics.drawable.BitmapDrawable at org.mozilla.gecko.prompts.PromptListAdapter.maybeUpdateIcon(PromptListAdapter.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-6e0796e8-1b52-4cac-ab64-a2c820170706.
=============================================================

Looks like we get a VectorDrawable somehow but are expecting a BitmapDrawable.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

Review commit: https://reviewboard.mozilla.org/r/155956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155956/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8885106 [details]
Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

Hi Sebastian
Since we are not using VectorDrawable, may I know when will I get VectorDrawable in PromptListItem?
Thanks!

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8885106 [details]
Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155956/diff/1-2/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Max
Here's my proposed solution.
Maybe you can help find the root cause :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8885106 [details]
Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

https://reviewboard.mozilla.org/r/155956/#review161182

Were you be able to find a situation in which this happens? Have you been able to test your patch?

Comment 6

[Max Liu [:maliu]]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Comment on attachment 8885106 [details]
> Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.
> 
> https://reviewboard.mozilla.org/r/155956/#review161182
> 
> Were you be able to find a situation in which this happens? Have you been
> able to test your patch?

Hi Sebastian,

I'm able to reproduce it and verify the patch worked.

STR:
  * Install a sample app with an activity filters action:"android.intent.action.SEND" intent
  * Let the icon of the activity be a VectorDrawable(ex. copy from ActivityStream as_xxxx.xml)
  * Long click on any link of a web page to bring up the context menu with share action

AR:
  * App crash because ClassCastException

ER:
  * Popup send-to app list

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d982adfcfb18
Fix ClassCastException if the icon is not a BitmapDrawable. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d982adfcfb18

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8885106 [details]
Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

Approval Request Comment
[Feature/Bug causing the regression]: App will crash if users want to share to apps with VectorDrawable icon.
[User impact if declined]: App will crash.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]: no
[Why is the change risky/not risky?]: just add more check. It's safer now.
[String changes made/needed]: no

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8885106 [details]
Bug 1378617 - Fix ClassCastException if the icon is not a BitmapDrawable.

fennec crash fix, beta55+

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c8bf2c45a10b