1378694 - [Form Autofill] Autofill fails on some of the main shopping sites

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]
Windows 10x64, Ubuntu 16.04, Mac Osx 10.12

Nightly 56.0a1 20170705170343

[Description:]
Autofill fails for several sites from the target tests sites as follows:

Amazon.com   - fail
Walmart.com  - fail
cdw.com      -fail
bestbuy.com  -fail
newegg.com   - fail


Sears.com - pass
Macys.com - pass


[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill. (default in Nightly)
Make sure you have at least one saved profile.


1.Open Firefox.
2.Navigate to Amazon.com and login with a valid account.
3.From the right corner hover Account &Lists and select account.
4.Click On Addresses button.
5.Click on Add Address.
6.Double click On Full name.
7.Double click on all the fields.


[Actual Result:]
The Form autofill is not triggered by any of the fields.


[Expected Result:]
The Form autofill is triggered by any of the fields given that you have profiles that contain that data.

[Note:]
This is a regression, on build from 28.06, all the sites from description had autofill working.

Regression range:
 
2:12.97 INFO: Last good revision: 8f80d594c08d5c7a112e5d4b9eb44ffca717eb7b
2:12.97 INFO: First bad revision: 6190181ff4093756d3f8df754109ed16d132d215
2:12.97 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f80d594c08d5c7a112e5d4b9eb44ffca717eb7b&tochange=6190181ff4093756d3f8df754109ed16d132d215

Comment 1

[Matthew N. [:MattN]]

Sean, can you look into this please?

Comment 2

[Sean Lee [:seanlee][:weilonge]]

After browsing these sites (Amazon.com, Walmart.com, bestbuy.com, newegg.com), the suspicious error is here:
00:52:40.784 TypeError: s is undefined 1 FormAutofillUtils.jsm:72:17

BTW, I can not access cdw.com without VPN. I suppose it's the same root cause for cdw.com.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1378694 - Make sure no null pointer before trimming string in FormAutofillUtils.toOneLineAddress.

Review commit: https://reviewboard.mozilla.org/r/155434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155434/

Comment 4

[Sean Lee [:seanlee][:weilonge]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c671d0286907b3716e4b614c19ef246a4c6c11e

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Hi Adrian, could you help to verify if the patch fixes the bug? Thank you.

Comment 6

[Adrian Florinescu [:aflorinescu]]

We've run the build on  Ubuntu 16.04 and the patch looks good on almost all sites. The only problem appears on cdw, but i guess that the form is a bit weird there. I wanted to get a reduced testcase for you, before posting in the bug, but I guess it looks good enough for central as it is:

Amazon.com   - pass
Walmart.com  - pass
cdw.com      - partial fail
bestbuy.com  -pass
newegg.com   - pass
Sears.com - pass
Macys.com - pass

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8884554 [details]
Bug 1378694 - Make sure no null pointer before trimming string in FormAutofillUtils.toOneLineAddress.

https://reviewboard.mozilla.org/r/155434/#review161530

::: browser/extensions/formautofill/FormAutofillUtils.jsm:72
(Diff revision 1)
>  
>      if (!Array.isArray(array)) {
> -      return null;
> +      return "";
>      }
>      return array
> -      .map(s => s.trim())
> +      .map(s => s ? s.trim() : null)

nit: s/null/""/

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8884554 [details]
Bug 1378694 - Make sure no null pointer before trimming string in FormAutofillUtils.toOneLineAddress.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155434/diff/1-2/

Comment 9

[Carsten Book [:Tomcat]]

has one open issue in mozreview that need to be fixed before we can use autoland. Can you take a look ? Thanks !

Comment 10

[Sean Lee [:seanlee][:weilonge]]

Sorry that I forget to mark the issue resolved. Please help to check-in again. Thanks.

Comment 11

[Carsten Book [:Tomcat]]

(In reply to Sean Lee [:seanlee][:weilonge] from comment #10)
> Sorry that I forget to mark the issue resolved. Please help to check-in
> again. Thanks.

np :) landed

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01b617a43277
Make sure no null pointer before trimming string in FormAutofillUtils.toOneLineAddress. r=lchang

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01b617a43277

Comment 14

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on 56.0a1 20170728100358 Windows 10x64/ Mac OSX 10.12.