Closed
Bug 137871
Opened 23 years ago
Closed 23 years ago
ArabicShaping() shouldn't require the source text to be in visual order
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.86 KB,
patch
|
ftang
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
This is part of the groundwork for bug 99823. ArabicShaping() currently assumes
that the source text is already in visual order, and lets the call site reverse
the text before calling.
|
Assignee | |
Comment 2•23 years ago
|
||
|
||
Comment 3•23 years ago
|
||
Comment on attachment 79727 [details] [diff] [review]
Patch
looks right in general. please write a function which do swaping and call that
function to do the swaping instead of add two for loops.
Attachment #79727 -
Flags: needs-work+
|
|
||
Comment 4•23 years ago
|
||
also, please add comment about the two flag you pass in. What do they mean ?
|
|
Assignee | |
Comment 5•23 years ago
|
||
Added comments on the flags and moved the for loops into a function
Attachment #79727 -
Attachment is obsolete: true
|
|
||
Comment 6•23 years ago
|
||
Comment on attachment 80110 [details] [diff] [review]
Patch v.2 addressing ftang's comments
r=ftang looks straight forward naming changes plus small tweak.
Attachment #80110 -
Flags: review+
|
||
Comment 7•23 years ago
|
||
Comment on attachment 80110 [details] [diff] [review]
Patch v.2 addressing ftang's comments
sr=attinasi
Attachment #80110 -
Flags: superreview+
|
|
Assignee | |
Comment 8•23 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•