137871 - ArabicShaping() shouldn't require the source text to be in visual order

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Simon Montagu :smontagu]

This is part of the groundwork for bug 99823. ArabicShaping() currently assumes
that the source text is already in visual order, and lets the call site reverse
the text before calling.

Comment 1

[Simon Montagu :smontagu]

Assigning to myself.

Comment 2

[Simon Montagu :smontagu]

Attachment: Patch

Comment 3

[Frank Tang]

Comment on attachment 79727 [details] [diff] [review]
Patch

looks right in general. please write a function which do swaping and call that
function to do the swaping instead of add two for loops.

Comment 4

[Frank Tang]

also, please add comment about the two flag you pass in. What do they mean ?

Comment 5

[Simon Montagu :smontagu]

Attachment: Patch v.2 addressing ftang's comments

Added comments on the flags and moved the for loops into a function

Comment 6

[Frank Tang]

Comment on attachment 80110 [details] [diff] [review]
Patch v.2 addressing ftang's comments

r=ftang looks straight forward naming changes plus small tweak.

Comment 7

[Marc Attinasi]

Comment on attachment 80110 [details] [diff] [review]
Patch v.2 addressing ftang's comments

sr=attinasi

Comment 8

[Simon Montagu :smontagu]

Fix checked in.