1378773 - In the autofill dropdown I don't see "Form Autofill..."

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[ovidiu boca[:Ovidiu]]

Environment:]

Windows, 
Nightly 56.0a1 20170705170357 

[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill. (default in Nightly)
Make sure you have at least two saved profile.


1.Open Firefox.
2. Navigate to https://luke-chang.github.io/autofill-demo/basic.html and double click on Name field. 
3.In the autofill drop-down, click on Form Autofill Preferences.



[Actual Result:]

On Windows, I see "Options".

[Expected Result:]
 
I should see "Form Autofill Options" or "Form Autofill Preferences"

Comment 1

[Ray Lin[:ralin]]

Thank you :ovidiu

We usually use "Options" in Windows/Linux, and "Preferences" in Mac. The string would also be different between 1-line and 2-lines layout, for the 2-lines layout, we shorten the string from "Form Autofill Options" to only "Options" in order to have a better fit in the footer. Those missing details should be specced, I'll ask UX double check current implementation and update the spec ASAP, then see if we can close this bug.

Comment 2

[ovidiu boca[:Ovidiu]]

That sounds good Ray, please let me know after the spec is updated. Thanks

Comment 3

[Juwei Huang[:juwei]]

Hi, for 2-line layout, the string would be "More Options". Please see visual spec: https://mozilla.invisionapp.com/share/GD8ND99QZ#/201881721_Suggestion_List_Spec
Thanks.

Comment 4

[Ray Lin[:ralin]]

(In reply to Juwei Huang[:juwei] from comment #3)
> Hi, for 2-line layout, the string would be "More Options". Please see visual
> spec:
> https://mozilla.invisionapp.com/share/GD8ND99QZ#/
> 201881721_Suggestion_List_Spec
> Thanks.

Thank you Juwei,

I'll have a quick fix to this.

Comment 5

[Ray Lin[:ralin]]

Attachment: Bug 1378773 - Replace "Options" with "More Options" in the autofill dropdown footer to conform with the spec.

Review commit: https://reviewboard.mozilla.org/r/155616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155616/

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8884735 [details]
Bug 1378773 - Replace "Options" with "More Options" in the autofill dropdown footer to conform with the spec.

https://reviewboard.mozilla.org/r/155616/#review161590

::: browser/extensions/formautofill/locale/en-US/formautofill.properties:20
(Diff revision 1)
>  updateAddressLabel = Update Address
>  openAutofillMessagePanel = Open Form Autofill message panel
>  autocompleteFooterOption = Form Autofill Options
> -autocompleteFooterOptionShort = Options
> +autocompleteFooterOptionShort = More Options
>  autocompleteFooterOptionOSX = Form Autofill Preferences
>  autocompleteFooterOptionOSXShort = Preferences

Should this change to "More Preferences" as well?

Comment 7

[Ray Lin[:ralin]]

(In reply to Luke Chang [:lchang] from comment #6)
> Comment on attachment 8884735 [details]
> Bug 1378773 - Replace "Options" with "More Options" in the autofill dropdown
> footer to conform with the spec.
> 
> https://reviewboard.mozilla.org/r/155616/#review161590
> 
> ::: browser/extensions/formautofill/locale/en-US/formautofill.properties:20
> (Diff revision 1)
> >  updateAddressLabel = Update Address
> >  openAutofillMessagePanel = Open Form Autofill message panel
> >  autocompleteFooterOption = Form Autofill Options
> > -autocompleteFooterOptionShort = Options
> > +autocompleteFooterOptionShort = More Options
> >  autocompleteFooterOptionOSX = Form Autofill Preferences
> >  autocompleteFooterOptionOSXShort = Preferences
> 
> Should this change to "More Preferences" as well?

No, I discussed with Juwei about this string, and she said we can leave it as-is for now. Thanks.

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8884735 [details]
Bug 1378773 - Replace "Options" with "More Options" in the autofill dropdown footer to conform with the spec.

https://reviewboard.mozilla.org/r/155616/#review161878

Got it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106e48e65b1b
Replace "Options" with "More Options" in the autofill dropdown footer to conform with the spec. r=lchang

Comment 10

[Ray Lin[:ralin]]

Thank you Luke :D

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/106e48e65b1b

Comment 12

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on 56.0a1 20170728100358 Windows 10x64.