1378816 - Talos sessionrestore tests do not produce a stack when the browser hangs

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Geoff Brown [:gbrown]]

See bug 934310: There is a mozharness timeout after 3600 seconds, presumably before Talos has given up on firefox.

I suspect firefox is hung but the Talos timeout is greater than the mozharness timeout, so firefox is not killed by Talos and no crash report is generated.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: use a 900 second browser timeout

The sessionrestore test has been using a timeout of 1000000 seconds -- far longer than mozharness will wait for the harness to complete. As a result, when the browser hangs, the harness does not timeout before mozharness kills it, resulting in a timeout failure (reported in bug 934310) without a crash report.

This reduces the timeout to 900 seconds, so that the Talos harness will wait only 15 minutes for each browser session.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e29a7eb9f8298acc6b1fd15eead8d45147336f54 reproduces the hang from bug 934310 with the 900 s timeout and successfully produces crash reports.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8884038 [details] [diff] [review]
use a 900 second browser timeout

Review of attachment 8884038 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b7b3cc327a
Use a reasonable browser timeout in sessionrestore talos test; r=ahal

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0b7b3cc327a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/af19dfa52f6a