Open Bug 1378845 Opened 7 years ago Updated 2 years ago

stylo: Use placement new for Gecko_CreateCSSErrorReporter

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?

People

(Reporter: jdm, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [stylo]) 

>::: layout/style/ServoBindings.cpp
>@@ +2615,5 @@
>> +ErrorReporter*
>> +Gecko_CreateCSSErrorReporter(ServoStyleSheet* sheet,
>> +                             Loader* loader)
>> +{
>> +  return new ErrorReporter(sheet, loader);
>
>Can you file a bug to avoid the heap allocation here using placement new in the 
>same fashion we do for the StyleChildrenIterator, and reference it from here?
Summary: Use placement new for Gecko_CreateErrorReporter → Use placement new for Gecko_CreateCSSErrorReporter
Blocks: stylo-perf
No longer blocks: 1352669
Depends on: 1352669
Summary: Use placement new for Gecko_CreateCSSErrorReporter → stylo: Use placement new for Gecko_CreateCSSErrorReporter
Blocks: 1371496
Priority: -- → P4
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.