Closed
Bug 1378847
Opened 7 years ago
Closed 7 years ago
Stop using sdk/core/heritage in DevTools shared/widgets
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: sole, Assigned: zer0)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
Used in: - devtools/client/shared/widgets/tooltip/SwatchColorPickerTooltip.js - devtools/client/shared/widgets/tooltip/SwatchCubicBezierTooltip.js - devtools/client/shared/widgets/tooltip/SwatchFilterTooltip.js More details to follow as we triage.
|
||
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
|
|
||
Updated•7 years ago
|
Assignee: nobody → yulia.startsev
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
|
|
||
Updated•7 years ago
|
Target Milestone: Firefox 56 → Firefox 57
|
Assignee | |
Updated•7 years ago
|
Assignee: yulia.startsev → zer0
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•7 years ago
|
||
Julian, since it seems we're doing the quickest way to remove the SDK dependencies, I just replaced the SDK's extend with ours. And maybe we can have a follow up bug that is not blocking NoSDK project to replace `extend` with ES6 classes.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900225 [details] Bug 1378847 - Replaced SDK `extend` with DevTools `extend`; https://reviewboard.mozilla.org/r/171596/#review176810 Looks good to me, with a green try. Two potential follow ups here: - move the Tooltips to ES6 classes - remove/merge the duplicated extend helper found in view-helpers.js [1] [1] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/devtools/client/shared/widgets/view-helpers.js#20-37
Attachment #8900225 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Try seems green for this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd7b75a789e3f9642d04f0df6352e46110a05421 https://treeherder.mozilla.org/#/jobs?repo=try&revision=760d564c7ec9fda0b2e556a95984030b8138676a
Pushed by mferretti@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f5fd2acdc01a Replaced SDK `extend` with DevTools `extend`; r=jdescottes
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5fd2acdc01a
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•