1378847 - Stop using sdk/core/heritage in DevTools shared/widgets

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Soledad Penades [:sole] [:spenades]]

Used in: 

- devtools/client/shared/widgets/tooltip/SwatchColorPickerTooltip.js
- devtools/client/shared/widgets/tooltip/SwatchCubicBezierTooltip.js
- devtools/client/shared/widgets/tooltip/SwatchFilterTooltip.js

More details to follow as we triage.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1378847 - Replaced SDK `extend` with DevTools `extend`;

Review commit: https://reviewboard.mozilla.org/r/171596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171596/

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Julian, since it seems we're doing the quickest way to remove the SDK dependencies, I just replaced the SDK's extend with ours. And maybe we can have a follow up bug that is not blocking NoSDK project to replace `extend` with ES6 classes.

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8900225 [details]
Bug 1378847 - Replaced SDK `extend` with DevTools `extend`;

https://reviewboard.mozilla.org/r/171596/#review176810

Looks good to me, with a green try.

Two potential follow ups here:
- move the Tooltips to ES6 classes
- remove/merge the duplicated extend helper found in view-helpers.js [1]

[1] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/devtools/client/shared/widgets/view-helpers.js#20-37

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Try seems green for this patch:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd7b75a789e3f9642d04f0df6352e46110a05421
https://treeherder.mozilla.org/#/jobs?repo=try&revision=760d564c7ec9fda0b2e556a95984030b8138676a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5fd2acdc01a
Replaced SDK `extend` with DevTools `extend`; r=jdescottes

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f5fd2acdc01a