Closed Bug 1378851 Opened 3 years ago Closed 3 years ago

Stop using sdk/core/heritage in DevTools highlighters

Categories

(DevTools :: General, enhancement, P1)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: sole, Assigned: pbro)

References

Details

(Whiteboard: [nosdk])

Attachments

(1 file)

Used in:

devtools/server/actors/highlighters/box-model.js
devtools/server/actors/highlighters/css-grid.js
devtools/server/actors/highlighters/css-transform.js
devtools/server/actors/highlighters/geometry-editor.js

More details to follow as we triage.
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
I'll try and do this one now.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Tests still pass locally, and I manually tested devtools too, but just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32363a8ec8e848a79c2677be05c144608d6a6e41
Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159768/#review165118

It looks like a fairly simple change, since thankfully the classes weren't extending any SDK classes! Nice :)
Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159770/#review165120
Attachment #8888737 - Flags: review?(sole) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c43cee08f5b
Use ES classes in devtools highlighters rather than SDK heritage module; r=sole
Priority: P2 → P1
Target Milestone: --- → Firefox 56
https://hg.mozilla.org/mozilla-central/rev/8c43cee08f5b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.