1378851 - Stop using sdk/core/heritage in DevTools highlighters

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Soledad Penades [:sole] [:spenades]]

Used in:

devtools/server/actors/highlighters/box-model.js
devtools/server/actors/highlighters/css-grid.js
devtools/server/actors/highlighters/css-transform.js
devtools/server/actors/highlighters/geometry-editor.js

More details to follow as we triage.

Comment 1

[Patrick Brosset <:pbro>]

I'll try and do this one now.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

Review commit: https://reviewboard.mozilla.org/r/159770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159770/

Comment 3

[Patrick Brosset <:pbro>]

Tests still pass locally, and I manually tested devtools too, but just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32363a8ec8e848a79c2677be05c144608d6a6e41

Comment 4

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159768/#review165118

It looks like a fairly simple change, since thankfully the classes weren't extending any SDK classes! Nice :)

Comment 5

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159770/#review165120

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c43cee08f5b
Use ES classes in devtools highlighters rather than SDK heritage module; r=sole

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c43cee08f5b