1378853 - Stop using sdk/core/heritage in DevTools reflow actor

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Soledad Penades [:sole] [:spenades]]

Used in: devtools/server/actors/reflow.js

More details to follow as we triage.

Comment 1

[Soledad Penades [:sole] [:spenades]]

Attachment: Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.

Review commit: https://reviewboard.mozilla.org/r/158786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158786/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8887858 [details]
Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.

https://reviewboard.mozilla.org/r/158786/#review164068

Looks good to me!

::: devtools/server/actors/reflow.js:473
(Diff revision 1)
>   * Reports window resize events on the tabActor's windows.
>   * @extends Observable
>   * @param {TabActor} tabActor
>   * @param {Function} callback Executed everytime a resize occurs
>   */
> -function WindowResizeObserver(tabActor, callback) {
> +

nit: remove extra line between comment block and class

Comment 3

[Soledad Penades [:sole] [:spenades]]

Attachment: Addressed review nits w/whitespace

Review commit: https://reviewboard.mozilla.org/r/158800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158800/

Comment 4

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8887858 [details]
Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158786/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1efe09393b6c
Stop using sdk/core/heritage in DevTools reflow actor. r=jdescottes

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1efe09393b6c