Stop using sdk/core/heritage in DevTools reflow actor

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: sole, Assigned: sole)

Tracking

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [nosdk])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 months ago
Used in: devtools/server/actors/reflow.js

More details to follow as we triage.

Updated

7 months ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
(Assignee)

Updated

7 months ago
Assignee: nobody → sole

Updated

7 months ago
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8887858 [details]
Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.

https://reviewboard.mozilla.org/r/158786/#review164068

Looks good to me!

::: devtools/server/actors/reflow.js:473
(Diff revision 1)
>   * Reports window resize events on the tabActor's windows.
>   * @extends Observable
>   * @param {TabActor} tabActor
>   * @param {Function} callback Executed everytime a resize occurs
>   */
> -function WindowResizeObserver(tabActor, callback) {
> +

nit: remove extra line between comment block and class
Attachment #8887858 - Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8887873 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 5

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1efe09393b6c
Stop using sdk/core/heritage in DevTools reflow actor. r=jdescottes
Keywords: checkin-needed

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1efe09393b6c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.