Stop using sdk/core/heritage in DevTools reflow actor

RESOLVED FIXED in Firefox 56

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: sole, Assigned: sole)

Tracking

unspecified
Firefox 56
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [nosdk])

Attachments

(1 attachment, 1 obsolete attachment)

Used in: devtools/server/actors/reflow.js

More details to follow as we triage.
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
Assignee: nobody → sole
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Comment on attachment 8887858 [details]
Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.

https://reviewboard.mozilla.org/r/158786/#review164068

Looks good to me!

::: devtools/server/actors/reflow.js:473
(Diff revision 1)
>   * Reports window resize events on the tabActor's windows.
>   * @extends Observable
>   * @param {TabActor} tabActor
>   * @param {Function} callback Executed everytime a resize occurs
>   */
> -function WindowResizeObserver(tabActor, callback) {
> +

nit: remove extra line between comment block and class
Attachment #8887858 - Flags: review?(jdescottes) → review+
Attachment #8887873 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1efe09393b6c
Stop using sdk/core/heritage in DevTools reflow actor. r=jdescottes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1efe09393b6c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.