Closed Bug 1378862 Opened 4 years ago Closed 4 years ago

Stop using sdk/core/heritage in DevTools shared protocol.js

Categories

(DevTools :: General, enhancement, P1)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: sole, Assigned: jdescottes)

References

(Depends on 1 open bug)

Details

(Whiteboard: [nosdk])

Attachments

(1 file)

Used in: devtools/shared/protocol.js

More details to follow as we triage.
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
Some of the classes in the file extend EventTarget, so can't reliably replace Class with ES6 class without possible issues here until we deal with the EventTarget bit. Blocked by bug 1381542 then :)
Depends on: 1381542
Repurposing Bug 1137935 to remove all usage of sdk/* in shared/protocol.js
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1137935
Whiteboard: [nosdk]
Sorry about that but Bug 1137935 ended up taking a slightly different direction and this still needs to be addressed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: [nosdk]
Status: REOPENED → NEW
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 57
This is a very conservative patch, that allows to get rid of the SDK APIs but should have several followups for cleanup and improvements.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4e6f5c291677fcf5feca1110c6e918b394a951e
Here is the list of followups that should be filed if we go for this:
- always call Arg, Option and RetVal with the new keyword
- migrate Arg, Option and RetVal to ES6 classes
- use constructor instead of initialize in actors and fronts that inherit Actor/Front classes
- migrate Pool, Actor and Front to ES6 classes
Comment on attachment 8899568 [details]
Bug 1378862 - remove usage of sdk heritage in devtools protocol.js;

https://reviewboard.mozilla.org/r/170868/#review177408

If we're going to have follow up bugs as we discussed, I don't have anything to complain or add to this, it looks good to me; so if tests are passing, let's ship it.
Attachment #8899568 - Flags: review?(zer0) → review+
Thanks for the review! Just pushed to try and rebased on the latest central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da352b5ba4044eb37d34106074d4982c7b45b679

Will log the follow ups while waiting for the results.
Depends on: 1393606
Depends on: 1393615
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/115d4b8f1f0a
remove usage of sdk heritage in devtools protocol.js;r=zer0
https://hg.mozilla.org/mozilla-central/rev/115d4b8f1f0a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
No longer depends on: 1393615
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.