1378864 - Stop using sdk/core/heritage in DevTools shared specs/string

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P1)

Description

[Soledad Penades [:sole] [:spenades]]

Used in: devtools/shared/specs/string.js

More details to follow as we triage.

Comment 1

[Soledad Penades [:sole] [:spenades]]

Taking this one

Comment 2

[Soledad Penades [:sole] [:spenades]]

Attachment: Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

Review commit: https://reviewboard.mozilla.org/r/162530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162530/

Comment 3

[Soledad Penades [:sole] [:spenades]]

A try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f32b74d19c95cc86dc67b9dfb3b568837ce052db&selectedJob=118894260

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168318

Looks great! Just one nit. Thanks for working on this, sole!

::: devtools/shared/specs/string.js:32
(Diff revision 1)
>  /**
>   * When a caller is expecting a LongString actor but the string is already available on
>   * client, the SimpleStringFront can be used as it shares the same API as a
>   * LongStringFront but will not make unnecessary trips to the server.
>   */
> -const SimpleStringFront = Class({
> +const SimpleStringFront = class SimpleStringFront {

I think you can just use:
```class SimpleStringFront {
…
}
```

Without the `const`. It's generally more consistent with the usage of `class` we've until now in our codebase. Unless there any specific reason you want to keep like this.

Comment 5

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162530/diff/1-2/

Comment 6

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168318

Fixed the nit!

Comment 7

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168788

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb2dff3fff69
Stop using sdk/core/heritage in DevTools shared specs/string. r=zer0

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb2dff3fff69