Closed
Bug 1378864
Opened 7 years ago
Closed 7 years ago
Stop using sdk/core/heritage in DevTools shared specs/string
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: sole, Assigned: sole)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
Used in: devtools/shared/specs/string.js More details to follow as we triage.
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
A try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f32b74d19c95cc86dc67b9dfb3b568837ce052db&selectedJob=118894260
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8891333 [details] Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string. https://reviewboard.mozilla.org/r/162530/#review168318 Looks great! Just one nit. Thanks for working on this, sole! ::: devtools/shared/specs/string.js:32 (Diff revision 1) > /** > * When a caller is expecting a LongString actor but the string is already available on > * client, the SimpleStringFront can be used as it shares the same API as a > * LongStringFront but will not make unnecessary trips to the server. > */ > -const SimpleStringFront = Class({ > +const SimpleStringFront = class SimpleStringFront { I think you can just use: ```class SimpleStringFront { … } ``` Without the `const`. It's generally more consistent with the usage of `class` we've until now in our codebase. Unless there any specific reason you want to keep like this.
Attachment #8891333 -
Flags: review?(zer0) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8891333 [details] Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string. https://reviewboard.mozilla.org/r/162530/#review168318 Fixed the nit!
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8891333 [details] Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string. https://reviewboard.mozilla.org/r/162530/#review168788
Attachment #8891333 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fb2dff3fff69 Stop using sdk/core/heritage in DevTools shared specs/string. r=zer0
Keywords: checkin-needed
Updated•7 years ago
|
Target Milestone: Firefox 56 → Firefox 57
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fb2dff3fff69
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•