Stop using sdk/core/heritage in DevTools shared specs/string

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: sole, Assigned: sole)

Tracking

unspecified
Firefox 57
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [nosdk])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Used in: devtools/shared/specs/string.js

More details to follow as we triage.

Updated

6 months ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
(Assignee)

Comment 1

6 months ago
Taking this one
Assignee: nobody → sole

Updated

6 months ago
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168318

Looks great! Just one nit. Thanks for working on this, sole!

::: devtools/shared/specs/string.js:32
(Diff revision 1)
>  /**
>   * When a caller is expecting a LongString actor but the string is already available on
>   * client, the SimpleStringFront can be used as it shares the same API as a
>   * LongStringFront but will not make unnecessary trips to the server.
>   */
> -const SimpleStringFront = Class({
> +const SimpleStringFront = class SimpleStringFront {

I think you can just use:
```class SimpleStringFront {
…
}
```

Without the `const`. It's generally more consistent with the usage of `class` we've until now in our codebase. Unless there any specific reason you want to keep like this.
Attachment #8891333 - Flags: review?(zer0) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

6 months ago
mozreview-review-reply
Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168318

Fixed the nit!
(Assignee)

Comment 7

6 months ago
mozreview-review
Comment on attachment 8891333 [details]
Bug 1378864 - Stop using sdk/core/heritage in DevTools shared specs/string.

https://reviewboard.mozilla.org/r/162530/#review168788
Attachment #8891333 - Flags: review+
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 8

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fb2dff3fff69
Stop using sdk/core/heritage in DevTools shared specs/string. r=zer0
Keywords: checkin-needed

Updated

6 months ago
Target Milestone: Firefox 56 → Firefox 57

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb2dff3fff69
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.