Closed Bug 1378867 Opened 8 years ago Closed 7 years ago

Use cssparser's identifier and string serialization routines in Stylo error reporter

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fix-optional

People

(Reporter: jdm, Unassigned)

References

Details

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1352669#c13: The routines in error_reporter.rs were ported from the C++ versions in nsStyleUtil.cpp. They are very similar to the serialize_identifier and CssStringWriter APIs that exist in rust-cssparser, except that they use numerical escapes for a wider set of characters. This is tested in test_parser_diagnostics_unprintables.html, but it would be worth figuring out if we could remove the duplicate code and settle on one implementation in the future.
Priority: -- → P4
This was done in https://github.com/servo/servo/commit/ad4fe4318794c51ea255ef486baab08f04f4db3e#diff-6d5f63742420613722936477261cb39e.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.