1378878 - Notification Service Extension incorrectly updates appPackage in the client record

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Both application and notification extension register a client record.

The records are mostly similar except for the ID and appPackage:

  org.mozilla.ios.Fennec
  org.mozilla.ios.Fennec.NotificationService

This results in multiple clients being shown in the device list.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

So after investigating more, I don't think this is the case. The confusion came from another bug: the NotificationService extension was updating the client record with its own bundle identifier, $BASEBUNDLEIDENTIFIER.NotifictionService.

I think what I saw was not pairs or app and extension, I think what I saw was simply a mix of unique records for unique test clients (i have a lot) that were randomly set to either.

The patch attached to this bug fixes the appPackage problem. And bug 1378877 will make sure that the version number in the client record is updated correctly. (It is set to 1.0 in the NotificationService Info.plist, while it should follow the main app's version)

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/2895

This patch sets the appPackage to the main application bundle identifier. This prevents extensions to write their own bundle identifier.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x