1378935 - auth/test_backends.py taskcluster scope_match is deprecated warning

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Seen in warnings output when a test fails in Vagrant:

tests/auth/test_backends.py::test_find_user_by_email[mozilla-ldap/[e-mail][e-mail]-scopes0-user0-False]
  /home/vagrant/python/lib/python2.7/site-packages/taskcluster/utils.py:250: UserWarning: NOTE: scope_match is deprecated.  Use scopeMatch
    warnings.warn('NOTE: scope_match is deprecated.  Use scopeMatch')

Comment 1

[Ed Morley [:emorley]]

Example warning on Travis:
https://travis-ci.org/mozilla/treeherder/jobs/250458786#L707

The offending code can be found here:
https://github.com/mozilla/treeherder/search?q=scope_match&type=

Comment 2

[u598527]

Hi! I would like to use this to learn the process of submitting patches. Can I help?

Comment 3

[Ed Morley [:emorley]]

(The account in comment 2 has been disabled)

For anyone else wanting to work on this, please see:
https://treeherder.readthedocs.io/installation.html

Then replace usages of `scope_match` (search link in comment 1) with `scopeMatch`, run the tests locally, and then open a PR.

Comment 4

[Omar Akkila]

Hello, Ed! I'm new to OSS and looking for a simple bug to work on to get started. I believe solving this is straightforward, so I'll most likely open up a PR in the treeherder repo later this weekend. Thanks!

Comment 5

[Rupanshu Verma]

Hello, I have been developing web apps for last 2 years and I would like to be a part of open source community.Could you please help me get started.
Thank you!

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] omakk:fix-warning > mozilla:master

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8892066 [details] [review]
[treeherder] omakk:fix-warning > mozilla:master

Hey Omar, usually you need to flag someone for review with these patches/pr's. I assigned this one to :camd.

Comment 8

[William Lachance (:wlach)]

(In reply to Rupanshu Verma from comment #5)
> Hello, I have been developing web apps for last 2 years and I would like to
> be a part of open source community.Could you please help me get started.
> Thank you!

Hi Rupanshu, looks like this one already has a patch. Hopefully you can find something else to work on. :)

Comment 9

[Omar Akkila]

(In reply to William Lachance (:wlach) (use needinfo!) from comment #7)
> Comment on attachment 8892066 [details] [review]
> [treeherder] omakk:fix-warning > mozilla:master
> 
> Hey Omar, usually you need to flag someone for review with these
> patches/pr's. I assigned this one to :camd.

Sorry about that, William - I wasn't aware of the procedure. Hopefully everything else is in order. Thanks for letting me know :)

Comment 10

[Cameron Dawson [:camd]]

Comment on attachment 8892066 [details] [review]
[treeherder] omakk:fix-warning > mozilla:master

Omak--  Just need the commit message fixed.  Otherwise, this will be good to merge.  Thanks for the patch!  Please reassign to me once fixed.

Comment 11

[Omar Akkila]

Comment on attachment 8892066 [details] [review]
[treeherder] omakk:fix-warning > mozilla:master

Should be good now. Thanks for reviewing!

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/73a7770a7fd01ab6dbf2571ad1eb0551312fea4c
Bug 1378935 - Replace deprecated scope_match with scopeMatch (#2671)

Comment 13

[Cameron Dawson [:camd]]

Comment on attachment 8892066 [details] [review]
[treeherder] omakk:fix-warning > mozilla:master

Thank you!!