Closed
Bug 1379113
Opened 7 years ago
Closed 7 years ago
Deleting non-existing URL query parameters should remove ?
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: annevk, Assigned: baku)
Details
Attachments
(1 file, 1 obsolete file)
|
1.98 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
|
||
Comment 1•7 years ago
|
||
Rather surprising, but I guess there is some reason.
|
Reporter | |
Comment 2•7 years ago
|
||
We could change the standard instead (someone suggested as much at https://github.com/whatwg/url/issues/332), but it's always been this way. It's just that until now nobody found this bug in Chrome and Firefox (Safari implements the standard).
|
||
Updated•7 years ago
|
Priority: -- → P2
|
|
Reporter | |
Comment 3•7 years ago
|
||
We ended up changing the standard instead, but Firefox still has a test failure as delete("non-existing-key") is a no-op, but it shouldn't be (sort() does end up updating so it seems like it's just an inconsistency).Summary: Deleting URL query parameters should not remove ? → Deleting non-existing URL query parameters should remove ?
|
Assignee | |
Comment 4•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8887067 -
Flags: review?(kyle)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8887067 [details] [diff] [review] urlsearchparams.patch Review of attachment 8887067 [details] [diff] [review]: ----------------------------------------------------------------- No commit message?
Attachment #8887067 -
Flags: review?(kyle) → review-
|
|
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8887067 -
Attachment is obsolete: true
Attachment #8887808 -
Flags: review?(kyle)
|
|
||
Updated•7 years ago
|
Attachment #8887808 -
Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/78ea9fac3a58 Deleting non-existing URL query parameters should remove ?, r=qdot
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/78ea9fac3a58
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•