Filtering in CachePerfStats::MMA::AddValue is too strict

RESOLVED FIXED in Firefox 56

Status

()

Core
Networking: Cache
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: michal, Assigned: michal)

Tracking

(Blocks: 1 bug)

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 months ago
Filtering based on max difference avg/4 + 2*stddev seems to be too strict. It's applied only on high values, so any low value pulls the average down. We include values from events that spent up to 5 event cycles in the queue, so we need to be more flexible here.
(Assignee)

Comment 1

10 months ago
Created attachment 8884263 [details] [diff] [review]
fix

Filtering of the values is now more relaxed. Also, stats for IO_WRITE isn't used in CachePerfStats::IsCacheSlow for detecting slow cache. Writes have low priority and it's normal that they are delayed a lot, but this doesn't necessarily affect opening cache entries.
Attachment #8884263 - Flags: review?(valentin.gosu)
Comment on attachment 8884263 [details] [diff] [review]
fix

Review of attachment 8884263 [details] [diff] [review]:
-----------------------------------------------------------------

nit: It's worth adding comments on why we ignore the write operations from the cache speed estimation.
Attachment #8884263 - Flags: review?(valentin.gosu) → review+
(Assignee)

Comment 3

10 months ago
Created attachment 8885727 [details] [diff] [review]
patch v2 - added comment
Attachment #8884263 - Attachment is obsolete: true
Attachment #8885727 - Flags: review+

Comment 4

10 months ago
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c098eb60dd1
Filtering in CachePerfStats::MMA::AddValue is too strict, r=valentin

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0c098eb60dd1
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.