1379210 - Layout issue with Learn more link for "Use Tracking Protection to block known trackers"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Francesco Lodolo [:flod]]

Attachment: prefs.png

As you can see from the attachment, it currently looks quite ugly in localize nightly (Italian).

The text is longer than English, and forces the Learn more link to move on the next line, where it's displayed with a padding.

I wonder if we could move down the buttons to gain more space, and possibly figure out a better way to deal with these Learn more links.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: 57beta.png

This just moved from ugly (on nightly) to broken on 57 Beta. It looks like there's a missing space between the link and the text, and I expect other languages to be as broken.

I'd suggest to review the priority of this bug at this point.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Evan could you take a look?

Comment 3

[Evan Tseng [:evanxd]]

Sure.

Comment 4

[Evan Tseng [:evanxd]]

Attachment: Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

Review commit: https://reviewboard.mozilla.org/r/184968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184968/

Comment 5

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thank you.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

https://reviewboard.mozilla.org/r/184968/#review190142

Much better, thanks!

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

https://reviewboard.mozilla.org/r/184968/#review190260

This changeset will break entire RWD experience if we shrink window to smaller size (with `privacy.trackingprotection.ui.enabled = false`). See attatchement.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Attachment: label-too-long.png

I can see an additional horizontal scrollbar in smaller browser window size.

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184968/diff/1-2/

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184968/diff/2-3/

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

https://reviewboard.mozilla.org/r/184968/#review191004

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc8d919ff430
Add a space between the trackingProtectionPBM checkbox and the learn more link. r=mconley,rickychien

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc8d919ff430

Comment 14

[Evan Tseng [:evanxd]]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1398050

[User impact if declined]: There is not space between trackingProtectionPBM checkbox and the learn more link. Check the screenshot https://bug1379210.bmoattachments.org/attachment.cgi?id=8912521.

[Is this code covered by automated tests?]: No.

[Has the fix been verified in Nightly?]: No. 

[Needs manual test from QE? If yes, steps to reproduce]: Yes.
STR:
1. Set the `privacy.trackingprotection.ui.enabled` config as `false`
2. Check the "Use Tracking Protection to block known trackers" in the Tracking Protection section.

Expected result
There is a space between the trackingProtectionPBM checkbox and the learn more link.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: We only added a spacer element in the xul document to fix it.

[String changes made/needed]: No.

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8913591 [details]
Bug 1379210 - Add a space between the trackingProtectionPBM checkbox and the learn more link.

Photon related fit and finish, Beta57+

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/27d586cdc726

Comment 17

[Hani Yacoub, Desktop QA]

ID build: 20171005195903
User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 58.0a1 and Beta 57.0b6 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.