Currently there are no tests run against the mozilla-platform-ops/devservices-aws repo where the Treeherder RDS configs live, making it harder for us to know we're not breaking things (exacerbated by our lack of familiarity with Terraform). I spotted there are a few nice ways to test Terraform configs plus related assets (eg json/shell files), for example what Travis use for their Terraform test run: https://github.com/travis-infrastructure/terraform-config/blob/7ed91676a42e17e2e6d03ecaa699c3f615acd4bd/runtests#L43
Created attachment 8884332 [details] [review] devservices-aws PR#55: Add some tests and a Travis configuration
Comment on attachment 8884332 [details] [review] devservices-aws PR#55: Add some tests and a Travis configuration Review of attachment 8884332 [details] [review]: ----------------------------------------------------------------- This is great! I'm all for CI checks although we might want to consider adding a notifications section. And since there are multiple stakeholders with regards to this repo I think Kendall would probably like to have some input here. Let's wait will he is back from PTO (next week) for his input.
(In reply to Jake Watkins [:dividehex] from comment #2) > This is great! I'm all for CI checks although we might want to consider > adding a notifications section. Yeah definitely worth considering, though even without it the PR status still shows up so warns people before merging (I see preventing a bad merge as the desired goal rather than notifying retrospectively that master is broken etc). For bonus points, someone with repo admin access can enable the "block merges unless CI has passed" option after this lands. > Let's wait will he is back from PTO (next week) for his input. Sounds good :-) Whilst working on this I also spotted some bugs in the upstream Travis test wrapper script that I used as inspiration, for which I've opened: https://github.com/travis-infrastructure/terraform-config/issues/185
Merged. Waiting on github support to unflag the new account I set up (devsvcs-travis) to connect the travis tests.
Great - thank you :-)
Done and working! Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.