Closed
Bug 1379221
Opened 8 years ago
Closed 8 years ago
combine _matchesList and_csvMatchesRule
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Unassigned, Mentored)
References
Details
(Whiteboard: [lang=python][ready][good first bug])
These two methods of the Rules table in Balrog's database later do nearly the same thing -- except _csvMatchesRule supports substring matching in addition to full string matching. We should combine the two.
https://github.com/mozilla/balrog/blob/f8d9bd8c054ff26d70b76e633f53032c739ac789/auslib/db.py#L1508
| Reporter | ||
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [lang=python][ready][good first bug]
| Reporter | ||
Updated•8 years ago
|
Mentor: bhearsum
Comment 1•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/a10b66786774262397a51e77931525ea2c0cbbdc
bug 1379221: combine _matchesList and_csvMatchesRule (#366). r=bhearsum
| Reporter | ||
Comment 2•8 years ago
|
||
This is in production.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•