1379241 - support WAV format for MediaRecorder

Status: NEW

(Core :: Audio/Video: Recording, enhancement, P3)

Description

[Viga]

currently, only ogg is supported for MediaRecorder(audio),
Please support wav format.

Comment 1

[Michael Froman [:mjf]]

(In reply to Viga from comment #0)
> currently, only ogg is supported for MediaRecorder(audio),
> Please support wav format.

Viga, can you try going here: https://www.webrtc-experiment.com/RecordRTC/  In the 'Start Recording' section, I selected 'Microphone' and 'pcm'.  After recording a bit of audio and clicking 'Save To Disk' it asked me to save a '.wav' file.

Comment 2

[Viga]

Which FireFox version do you use? Or do you use other browser, like Chrome?

Comment 3

[Michael Froman [:mjf]]

(In reply to Viga from comment #2)
> Which FireFox version do you use? Or do you use other browser, like Chrome?

I ran that test on the current release of Firefox (54.0.1) on OSX 10.11.  I also just tried it on Ubuntu with Firefox (54.0) and it worked as well.

Comment 4

[Michael Froman [:mjf]]

Just to make sure I verified it also works on the Nightly build of Firefox 56.0a1 (2017-07-11).

Comment 5

[Viga]

Hi Michael,
I find source code,
https://dxr.mozilla.org/mozilla-central/source/dom/webidl
https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaRecorder.cpp
I don't see any audio/wav format encoded.

Maybe the link you post, it's not implemented by MediaRecorder.

Comment 6

[Viga]

https://github.com/streamproc/MediaStreamRecorder/blob/master/MediaStreamRecorder.js#L54
It clearly says, it's encoded in javascript.

Comment 7

[Michael Froman [:mjf]]

(In reply to Viga from comment #6)
> https://github.com/streamproc/MediaStreamRecorder/blob/master/
> MediaStreamRecorder.js#L54
> It clearly says, it's encoded in javascript.

My apologies!  I was just looking for something that potentially exercised MediaRecorder and found that demo.  I had not had a chance to walk the demo code.  I'll let :padenot adjust the priority on the bug after he has a chance to look at it.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

FWIW here's a fiddle that exercises MediaRecorder https://jsfiddle.net/jib1/pkc16k9r/

Comment 9

[Paul Adenot (:padenot)]

It's unclear if we have time to do that for now, but I suppose we would accept a patch.

Comment 10

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 11

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Moving to P3 as the meaning of P4 has changed since the bulk change above.

Comment 12

[guest271314]

Specification issue https://github.com/w3c/mediacapture-record/issues/198

Comment 13

[guest271314]

Chromium bug https://bugs.chromium.org/p/chromium/issues/detail?id=1070108

Comment 14

[guest271314]

(In reply to Paul Adenot (:padenot) from comment #9)

It's unclear if we have time to do that for now, but I suppose we would
accept a patch.

What is necessary for a patch?

Chromium appears to create WAV files for Chromecast and fake audio MediaStream testing https://bugs.chromium.org/p/chromium/issues/detail?id=421054 not sure how helpful they will be for Mozilla

• https://github.com/chromium/chromium/blob/a6674780859f9d3b05edf8dc71d179a44f0fc5fd/chromecast/media/cma/backend/cplay/wav_header.h
• https://github.com/chromium/chromium/blob/a6674780859f9d3b05edf8dc71d179a44f0fc5fd/chromecast/media/cma/backend/cplay/wav_header.h
• https://github.com/chromium/chromium/blob/cacc05d2d5ee2c1e42f1e7c9225a30e7b3f4f3e8/media/audio/wav_audio_handler.cc
• https://github.com/chromium/chromium/blob/b29e8a942dd6facfec8beccdada522c34a2225fc/media/audio/simple_sources.cc
• https://github.com/chromium/chromium/blob/2960b5338d084b30b77c352ffaa806a2403398eb/services/audio/public/cpp/sounds/audio_stream_handler.cc
• https://chromium.googlesource.com/chromium/src/+/4cdbc38ac425f5f66467c1290f11aa0e7e98c6a3/media/audio/fake_audio_input_stream.cc

Comment 15

[Abhishek]

I'm interested in taking a stab at this.