1379277 - bad change ids aren't handled well by history diff endpoints

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

We end with an exception (which throws a 500):
IndexError: list index out of range
  File "flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "flask/views.py", line 84, in view
    return self.dispatch_request(*args, **kwargs)
  File "flask/views.py", line 149, in dispatch_request
    return meth(*args, **kwargs)
  File "auslib/web/admin/views/releases.py", line 645, in get
    prev_id = self.get_prev_id(value, change_id)
  File "auslib/web/admin/views/releases.py", line 639, in get_prev_id
    return old_revision[0]['change_id']

We should probably be returning a 400 here instead.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/768ef2f75a4e03e05eccd88d9abfe484ba00c96e
bug 1379277: bad change ids aren't handled well by history diff endpoint (#374). r=bhearsum

Comment 2

[[e-mail] (:bhearsum)]

Deployed to production yesterday. Thanks Bhavishya!