Closed Bug 1379285 Opened 7 years ago Closed 7 years ago

handle requests that set bad values for "force" query parameter

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rveeranki01, Mentored)

References

Details

(Whiteboard: [lang=python][ready][good first bug]) 

Currently, we try to coerce it to an int, which fails for many, many things (https://github.com/mozilla/balrog/blob/d4b030dcf1c8fc097aaee6ffd7ac6366d70fcbf8/auslib/web/public/client.py#L71). We should probably just set force=True if the value is "1" and set force=False for any other value.
Mentor: bhearsum
Hi,I have created a pull request.
Flags: needinfo?(bhearsum)
(In reply to Hemant Singh Patwal [:hhhh1612] from comment #1)
> Hi,I have created a pull request.

Thank you! I replied in the PR.
Flags: needinfo?(bhearsum)
Hello team,I am new to open source.And I would love to work on this.How can I start to work on this?
Hi, I have submitted pull request https://github.com/mozilla/balrog/pull/384
Please have a look when you have time. Thanks!
Assignee: nobody → rveeranki01
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/47dd147b08ca308442915debea5018139751c5b3
bug 1379285: handle requests that set bad values for "force" query parameter (#384). r=bhearsum,allan-silva
Depends on: 1399179
This is now in production, thank you for the new tests Rajesh!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.