Closed
Bug 1379353
Opened 8 years ago
Closed 8 years ago
Improve the nsDiskCacheBinding.cpp hash routine
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
mayhemer
:
review-
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•8 years ago
|
||
Attachment #8884499 -
Flags: review?(mcmanus)
|
|
Reporter | |
Comment 2•8 years ago
|
||
Bug 1379282 is the motivation behind fixing this.
|
||
Comment 3•8 years ago
|
||
This is cache1 - no one is using it today.
|
|
Reporter | |
Comment 4•8 years ago
|
||
(In reply to Honza Bambas (:mayhemer) from comment #3)
> This is cache1 - no one is using it today.
It's used for appcache isn't it?
|
|
||
Comment 5•8 years ago
|
||
(In reply to (Away 7/10-7/17) from comment #4)
> (In reply to Honza Bambas (:mayhemer) from comment #3)
> > This is cache1 - no one is using it today.
>
> It's used for appcache isn't it?
I think nsDiskCacheBinding.cpp isn't. But I would have to double check. Anyway, the change is trivial, so we definitely can take it :)
|
||
Updated•8 years ago
|
Attachment #8884499 -
Flags: review?(mcmanus) → review?(honzab.moz)
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8884499 [details] [diff] [review]
Improve the nsDiskCacheBinding.cpp hash routine
Review of attachment 8884499 [details] [diff] [review]:
-----------------------------------------------------------------
MatchEntry needs an update too.
Attachment #8884499 -
Flags: review?(honzab.moz) → review-
|
|
||
Comment 7•8 years ago
|
||
And this code is not used for appcache, so it's not used at all... I would WONTFIX this...
|
||
Comment 8•8 years ago
|
||
WONTFIX based on Comment 7. Feel free to reopen it.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•