Zoom widget label should be fixed width

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Toolbars and Customization
P1
minor
VERIFIED FIXED
6 months ago
4 months ago

People

(Reporter: Alice0775 White, Assigned: mikedeboer)

Tracking

(Depends on: 1 bug, {polish})

Trunk
Firefox 57
Unspecified
All
polish
Points:
---

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [reserve-photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
It is annoying that +/- button position shifts when changing from 100% to 90% and vice versa.

Reproducible: always

Steps to reproduce:
1. Open Hamburger menu
2. When current zoom>=100%,
   Repeatedly click [-] button to zoom out, (easy to reproduce, click most left side of the button)

Actual Results:
Menu close suddenly, when zoom 100% to 90%
So, I can not zoom out with repeated clicks

Expected Results:
Menu should not close. And continuing I can zoom out with repeated clicks
  

 
Another steps to reproduce:
1. Place Zoom widget on toolbar
2. when current zoom<100%,
   Repeatedly click [+] button to zoom in, (easy to reproduce, click most left side of the button)

Actual Results:
Mouse pointer becomes on the Label of zoom level.
So, I can not zoom in with repeated clicks

Expected Results
Continuing I can zoom in with repeated clicks
(Reporter)

Updated

6 months ago
Keywords: polish

Comment 1

6 months ago
Given that this predates Photon, doesn't *need* to be in 57, but I agree that this would be nice to fix.
Flags: qe-verify+
Priority: -- → P3
Whiteboard: [reserve-photon-structure]

Updated

6 months ago
See Also: → bug 1327131

Updated

5 months ago
QA Contact: gwimberly

Updated

5 months ago
Priority: P3 → P4
Comment hidden (mozreview-request)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED

Comment 3

4 months ago
mozreview-review
Comment on attachment 8910264 [details]
Bug 1379357 - Ensure that the zoom button the app menu has a fixed width to fit the 100% label, so that the buttons next to it don't move when the label gets slimmer.

https://reviewboard.mozilla.org/r/181758/#review187094

I mean, r=me, but the bug explicitly also calls out the toolbar button item. Can we do the same thing there (when it's in the toolbar) ? Maybe as a separate cset, but still on this bug?
Attachment #8910264 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs from comment #3)
> I mean, r=me, but the bug explicitly also calls out the toolbar button item.
> Can we do the same thing there (when it's in the toolbar) ? Maybe as a
> separate cset, but still on this bug?

This is already dealt with for this control[1] when it's in a toolbar, so I don't how Alice was able to get this behavior to reproduce there.

[1] http://searchfox.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#1626
Flags: needinfo?(alice0775)

Comment 5

4 months ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/736598341c09
Ensure that the zoom button the app menu has a fixed width to fit the 100% label, so that the buttons next to it don't move when the label gets slimmer. r=Gijs
(Reporter)

Comment 6

4 months ago
(In reply to Mike de Boer [:mikedeboer] from comment #4)
> (In reply to :Gijs from comment #3)
> > I mean, r=me, but the bug explicitly also calls out the toolbar button item.
> > Can we do the same thing there (when it's in the toolbar) ? Maybe as a
> > separate cset, but still on this bug?
> 
> This is already dealt with for this control[1] when it's in a toolbar, so I
> don't how Alice was able to get this behavior to reproduce there.
> 
> [1]
> http://searchfox.org/mozilla-central/source/browser/themes/shared/
> customizableui/panelUI.inc.css#1626

In case of the zoom widget is in toolbar, it was already fixed by Bug 1377184.
Flags: needinfo?(alice0775)

Updated

4 months ago
Iteration: --- → 57.3 - Sep 19
Priority: P4 → P1

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/736598341c09
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Tested using Mac OSX 10.12.5 and Windows 7 x 64 on latest Nightly 57.0a1 , Build ID 20170921100141. The issue is not reproducible anymore. The Zoom (in/out)buttons have fixed width to fit any scale/labe (when accessing from toolbar or hamburger menu).  I will mark this as Verified Fixed. Thank you
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+

Updated

4 months ago
Depends on: 1403675
You need to log in before you can comment on or make changes to this bug.