Closed
Bug 1379368
Opened 7 years ago
Closed 7 years ago
About pages lost the proper styling in SeaMonkey Classic theme
Categories
(SeaMonkey :: Themes, defect)
Tracking
(seamonkey2.54 fixed, seamonkey2.53 fixed)
RESOLVED
FIXED
seamonkey2.54
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
4.70 KB,
patch
|
rsx11m.pub
:
review+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Bug 1367326 removed some styling options from about.css in toolkit. Most SeaMonkey about: pages are now an unappealing gray mess with the classic theme.
Comment 1•7 years ago
|
||
REPRODUCIBLE with unzipped installer of official en-US SeaMonkey 2.53a1 (NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0 Build 20170706013410 (Default Classic Theme) on German WIN7 64bit. Was still ok with Build 20170620091523, appeared within 2.53 But FRG already knows all details :-)
Version: Trunk → SeaMonkey 2.53 Branch
Assignee | ||
Comment 2•7 years ago
|
||
Confirmed that Modern is not affected. It already has its own about.css
Attachment #8884620 -
Flags: review?(rsx11m.pub)
Comment on attachment 8884620 [details] [diff] [review] 1379368-aboutcss.patch Ok, so we are forking yet another CSS style sheet for the default theme (sigh). Looks almost identical to prior mozilla-central changeset c92368a3d324, except for: >+++ b/suite/themes/classic/communicator/about.css >+ul { >+ margin: 0; >+ margin-inline-start: 1.5em; >+ padding: 0; >+} There was a "list-style: square;" in that definition, we don't want that any more? Most likely there is a reason, I'd just like to know it...
Attachment #8884620 -
Flags: review?(rsx11m.pub) → review+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/e85f8a58c5c1 Restore pre Photon styling for SeaMonkey about pages. r=rsx11m
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•7 years ago
|
||
> Ok, so we are forking yet another CSS style sheet for the default theme (sigh). Yeahh. Thought first to do an overlay but with the default sheet looking like <BEEP>, likely needing a ton of changes and only 58 lines I can live with it. > There was a "list-style: square;" in that definition, we don't want that any more? ahh oehhh I hmm... Ok, maybe removed in error :) Didn't notice it. The default circles looked ok and almost identical. Thanks for catching it. Added back in the push.
status-seamonkey2.53:
--- → affected
status-seamonkey2.54:
--- → fixed
Target Milestone: --- → seamonkey2.54
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8884620 [details] [diff] [review] 1379368-aboutcss.patch [Approval Request Comment] Regression caused by (bug #): 1367326 User impact if declined: about pages look bland and unappealing. Testing completed (on m-c, etc.): c-b Risk to taking this patch (and alternatives if risky): none String changes made by this patch: --
Attachment #8884620 -
Flags: approval-comm-beta?
Comment on attachment 8884620 [details] [diff] [review] 1379368-aboutcss.patch a=me for c-b
Attachment #8884620 -
Flags: approval-comm-beta? → approval-comm-beta+
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/656ff307995ad3c250e399571841530c9ad1d4e2
You need to log in
before you can comment on or make changes to this bug.
Description
•