1379387 - Want keyboard shortcuts to open the hamburger and overflow menus

Status: NEW

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Clément]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170707063454

Steps to reproduce:

open menu (burger icon on right of tool bar) with keyboard shortcut with


Actual results:

their is no shortcut for this menu, "alt" open the classic menu (file, edit, view, ...)


Expected results:

"alt" should open menu

Comment 1

[YF (Yang)]

As well as Overflow Menu.

Comment 2

[:Gijs (he/him)]

(In reply to Clément from comment #0)
> "alt" should open menu

We can't really do this, that would break Windows guidelines unless we actually removed the whole menubar (which we're not planning on doing for now), and it wouldn't make any sense on OS X, in addition to being problematic on some Linux desktop environments.

In general, there not being a keyboard shortcut isn't a regression so we will see if we have time for this, but can ship 57 without -> reserve.

Comment 3

[Clément]

It's also an accessibility issue

Comment 4

[Clément]

(In reply to :Gijs from comment #2)
> (In reply to Clément from comment #0)
> > "alt" should open menu
> 
> We can't really do this, that would break Windows guidelines unless we
> actually removed the whole menubar (which we're not planning on doing for
> now), and it wouldn't make any sense on OS X, in addition to being
> problematic on some Linux desktop environments.
> 
> In general, there not being a keyboard shortcut isn't a regression so we
> will see if we have time for this, but can ship 57 without -> reserve.

"alt" is only a suggestion (chromium use it)

why it it wouldn't make any sense on OS X?

Comment 5

[:Gijs (he/him)]

(In reply to Clément from comment #4)
> "alt" is only a suggestion (chromium use it)
> 
> why it it wouldn't make any sense on OS X?

Because you don't access toplevel menus that way on OS X. In fact, there is no convenient keyboard shortcut for the toplevel menubar at all by default (it's ctrl-f2 by default, but the function keys are turned off by default on laptops, so on my mbp it's the awkward ctrl-fn-f2). Chromium also doesn't use this key on OS X (not sure if they use anything else).

Comment 6

[Clément]

shortcut could be [ctrl+space] or other
menu button should also be accessible with [tab]/[shift+tab] (like site info button, urlbar, searchbar, ...)

Comment 7

[trysten]

Hamburger menu should highlight when tabbing among other elements in the same area, at least. Instead, tab focus skips from library button to page. The hamburger menu is navigable with arrow keys but unreachable via keyboard. This is broken UX.

Comment 8

[:Gijs (he/him)]

(In reply to trysten from comment #7)

Hamburger menu should highlight when tabbing among other elements in the same area, at least.

It does. You can arrow between buttons in each group of focusable buttons (switching between groups with tab), and can open the hamburger menu (and the overflow button, if visible) that way.

We haven't made all buttons tabbable because it's annoying to have to tab 15 times or so to get through all the items in the toolbar, when you usually don't want that.

Comment 9

[trysten]

Indeed! Not sure how I missed it, but I'm quite happy with the way it works now that I know. Sorry for putting a (what ended up being) support issue in a bug mailing list. I read through many issues and wanted to say I'm thankful for all your contributions, Gijs. Thank you, keep up the great work. I hope I will have something constructive to contribute someday :)

Comment 10

[max]

Isn't this issue a duplicate of the Bug #1259818?