1379394 - Add a pref to allow disabling one-touch-pinch zoom gesture

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Bug 1111333 added support for the one-touch-pinch gesture (aka double-tap-drag zoom gesture) that allows one-handed zooming on touch devices. However there is no way to turn it off if users find it annoying. We should add a pref to allow disabling it.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ.

Review commit: https://reviewboard.mozilla.org/r/155430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155430/

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8884549 [details]
Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ.

https://reviewboard.mozilla.org/r/155430/#review160496

::: gfx/layers/apz/src/AsyncPanZoomController.cpp:291
(Diff revision 1)
>   * \li\b apz.min_skate_speed
>   * Minimum amount of speed along an axis before we switch to "skate" multipliers
>   * rather than using the "stationary" multipliers.\n
>   * Units: CSS pixels per millisecond
>   *
> + * \li\b apz.one_touch_pinch.enabled

I don't find it particularly helpful to have two names - "one-touch pinch" and "double-tap drag to zoom" - for the same feature.

Could we pick one, and stick to it?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah I meant to stick with "one-touch-pimch" since that's what all the existing code uses.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8884549 [details]
Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155430/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4df531710d39
Add a pref to allow disabling the one-handed-zoom gesture in APZ. r=botond

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4df531710d39

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8884549 [details]
Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1111333
[User impact if declined]: no way to disable the feature added, which can result in unexpected behaviour
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: adding a pref; default behaviour is unchanged
[String changes made/needed]: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8884549 [details]
Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ.

add a pref to control one-handed-zoom, beta55+

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/507ce044e84f

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> [Is this code covered by automated tests?]: no
> [Has the fix been verified in Nightly?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Kartikaya's assessment on manual testing needs.

Comment 11

[Oana Horvath [:ohorvath - out of office]]

Verified the apz.one_touch_pinch.enabled pref is added and works in about:config on Beta 55.0b8 (2017-11-07).
Devices:
-HTC Nexus 9 (Android 7.1.1)