Closed
Bug 1379394
Opened 7 years ago
Closed 7 years ago
Add a pref to allow disabling one-touch-pinch zoom gesture
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox54 | --- | unaffected |
firefox55 | --- | verified |
firefox56 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
botond
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
Bug 1111333 added support for the one-touch-pinch gesture (aka double-tap-drag zoom gesture) that allows one-handed zooming on touch devices. However there is no way to turn it off if users find it annoying. We should add a pref to allow disabling it.
Assignee | ||
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox56:
--- → affected
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8884549 [details] Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ. https://reviewboard.mozilla.org/r/155430/#review160496 ::: gfx/layers/apz/src/AsyncPanZoomController.cpp:291 (Diff revision 1) > * \li\b apz.min_skate_speed > * Minimum amount of speed along an axis before we switch to "skate" multipliers > * rather than using the "stationary" multipliers.\n > * Units: CSS pixels per millisecond > * > + * \li\b apz.one_touch_pinch.enabled I don't find it particularly helpful to have two names - "one-touch pinch" and "double-tap drag to zoom" - for the same feature. Could we pick one, and stick to it?
Attachment #8884549 -
Flags: review?(botond) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Yeah I meant to stick with "one-touch-pimch" since that's what all the existing code uses.
Comment hidden (mozreview-request) |
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4df531710d39 Add a pref to allow disabling the one-handed-zoom gesture in APZ. r=botond
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4df531710d39
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8884549 [details] Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ. Approval Request Comment [Feature/Bug causing the regression]: bug 1111333 [User impact if declined]: no way to disable the feature added, which can result in unexpected behaviour [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: adding a pref; default behaviour is unchanged [String changes made/needed]: none
Attachment #8884549 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
Comment on attachment 8884549 [details] Bug 1379394 - Add a pref to allow disabling the one-handed-zoom gesture in APZ. add a pref to control one-handed-zoom, beta55+
Attachment #8884549 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/507ce044e84f
Comment 10•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #7) > [Is this code covered by automated tests?]: no > [Has the fix been verified in Nightly?]: yes > [Needs manual test from QE? If yes, steps to reproduce]: no Setting qe-verify- based on Kartikaya's assessment on manual testing needs.
Flags: qe-verify-
Comment 11•7 years ago
|
||
Verified the apz.one_touch_pinch.enabled pref is added and works in about:config on Beta 55.0b8 (2017-11-07). Devices: -HTC Nexus 9 (Android 7.1.1)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•