Closed
Bug 1379412
Opened 7 years ago
Closed 7 years ago
Bookmark created with blank/no name still has bookmark name in some cases and on browser restart after landing patch from bug #1360872
Categories
(Toolkit :: Places, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | verified |
People
(Reporter: Virtual, Assigned: lina)
References
Details
(Keywords: nightly-community, regression, reproducible)
Attachments
(1 file)
[Tracking Requested - why for this release]: Regression STR: 1. Add some bookmark with blank name to bookmarks and see that added bookmark have name, instead of having blank name with only favicon Workaround: Clear name second time to get blank name
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 1•7 years ago
|
||
I suspect that it could be caused by bug #1360872.
Blocks: 1360872
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Flags: needinfo?(Virtual)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 2•7 years ago
|
||
Better reproducible STR: 1. Bookmark this website page ( http://www.ldoceonline.com/ ) with blank/no name in "Bookmark Tooolbar" folder 2. Open Bookmark doorhanger and see that bookmark doesn't have name 3. Open Library and see that bookmark still have name
Component: Session Restore → Places
Flags: needinfo?(Virtual)
Keywords: reproducible
Product: Firefox → Toolkit
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Has STR: --- → yes
Summary: Bookmark created with blank/no name have bookmark name → Bookmark created with blank/no name still have bookmark name in some cases
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Summary: Bookmark created with blank/no name still have bookmark name in some cases → Bookmark created with blank/no name still has bookmark name in some cases
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 3•7 years ago
|
||
and on Firefox restart bookmark name will reappear again
Flags: needinfo?(kit)
Summary: Bookmark created with blank/no name still has bookmark name in some cases → Bookmark created with blank/no name still has bookmark name in some cases and on browser restart
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Updated•7 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
I think this worked before because we stored blank titles as `""`, so `IFNULL(b.title, h.title)` would return the empty string. Now, we store blank titles as `NULL`, so `IFNULL` would fall back to the visit title. This patch fixes the toolbar and Library views, but I'm wondering if it has other unintended consequences.
Flags: needinfo?(kit)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Has Regression Range: --- → yes
Keywords: regressionwindow-wanted
Summary: Bookmark created with blank/no name still has bookmark name in some cases and on browser restart → Bookmark created with blank/no name still has bookmark name in some cases and on browser restart after landing patches from bug #1360872
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Assignee: nobody → kit
Status: NEW → ASSIGNED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Summary: Bookmark created with blank/no name still has bookmark name in some cases and on browser restart after landing patches from bug #1360872 → Bookmark created with blank/no name still has bookmark name in some cases and on browser restart after landing patch from bug #1360872
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8884941 [details] Bug 1379412 - Don't fall back to the history visit title when fetching folder children. https://reviewboard.mozilla.org/r/155782/#review161614 Can we add a simple xpcshell-test for this? It may be just matter of checking titles in an nsNavHistoryQuery result after adding a bookmark with an empty title.
Attachment #8884941 -
Flags: review?(mak77) → review+
Comment hidden (mozreview-request) |
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e39010c3f233 Don't fall back to the history visit title when fetching folder children. r=mak
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e39010c3f233
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1380740
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 10•7 years ago
|
||
I'm confirming that it's fixed, starting in Mozilla Firefox 56.0a1 (2017-07-13) (64-bit). It's fixed partially, so leftover will be tracked in new bug #1380740. Thanks. I'm marking this bug as VERIFIED.
Status: RESOLVED → VERIFIED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
tracking-firefox56:
- → ---
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•