1379430 - js/src/wasm/WasmSignalHandlers.cpp:439:39: error: use of undeclared identifier 'R31_sig'

Assignee

Description

•

7 years ago

mozilla-central changeset 40dc967db051 fixed only Linux, other aarch64 platforms remain broken.

$ pkg install autoconf213 gmake python27
$ cd js/src/
$ autoconf-2.13
$ ./configure --disable-jemalloc
$ gmake
[...]
In file included from js/src/js/src/Unified_cpp_js_src42.cpp:47:
js/src/wasm/WasmSignalHandlers.cpp:439:39: error: use of undeclared identifier
      'R31_sig'
    return reinterpret_cast<uint8_t*>(SP_sig(context));
                                      ^
js/src/wasm/WasmSignalHandlers.cpp:406:20: note: expanded from macro 'SP_sig'
# define SP_sig(p) R31_sig(p)
                   ^
1 error generated.

Comment hidden (mozreview-request)

Properly define RLR_sig and R31_sig based on:
https://github.com/freebsd/freebsd/blob/master/sys/arm64/include/ucontext.h
https://github.com/openbsd/src/blob/master/sys/arch/arm64/include/signal.h
https://github.com/netbsd/src/blob/trunk/sys/arch/aarch64/include/mcontext.h

Review commit: https://reviewboard.mozilla.org/r/155478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155478/

Jan Beich

Assignee

Updated

•

7 years ago

Whiteboard: [npotb]

Jan Beich

Assignee

Comment 2

•

7 years ago

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

# SpiderMonkey 55.0 on ref11-aarch64.freebsd.org
$ cd dist/bin

$ for f in Test*; do echo "=== $f ==="; ./$f; done
=== TestArray ===
=== TestArrayUtils ===
=== TestAtomics ===
=== TestBinarySearch ===
=== TestBloomFilter ===
=== TestBufferList ===
=== TestCasting ===
=== TestCeilingFloor ===
=== TestCheckedInt ===
0 tests failed, 5033 tests passed out of 5033 tests, covering 11 distinct integer types.
=== TestCountPopulation ===
=== TestCountZeroes ===
=== TestDoublyLinkedList ===
=== TestEndian ===
=== TestEnumSet ===
=== TestEnumTypeTraits ===
=== TestEnumeratedArray ===
=== TestFastBernoulliTrial ===
=== TestFloatingPoint ===
=== TestIntegerPrintfMacros ===
=== TestIntegerRange ===
=== TestJSONWriter ===
=== TestLinkedList ===
=== TestMacroArgs ===
=== TestMacroForEach ===
=== TestMathAlgorithms ===
=== TestMaybe ===
=== TestNotNull ===
=== TestPair ===
=== TestPoisonArea ===
INFO | negative control allocated at 0x0000000040431000
INFO | positive control allocated at 0x0000000040432000
INFO | poison area assumed at 0x7ffffffff0dea000
TEST-PASS | reading negative control
TEST-PASS | executing negative control
TEST-PASS | writing negative control
TEST-PASS | reading positive control | signal 11 (as expected)
TEST-PASS | executing positive control | signal 11 (as expected)
TEST-PASS | writing positive control | signal 11 (as expected)
TEST-PASS | reading poison area | signal 11 (as expected)
TEST-PASS | executing poison area | signal 11 (as expected)
TEST-PASS | writing poison area | signal 11 (as expected)
=== TestRange ===
=== TestRefPtr ===
=== TestResult ===
=== TestRollingMean ===
=== TestSHA1 ===
=== TestSaturate ===
=== TestScopeExit ===
=== TestSegmentedVector ===
=== TestSmallPointerArray ===
=== TestSplayTree ===
=== TestTemplateLib ===
=== TestTuple ===
=== TestTypeTraits ===
=== TestTypedEnum ===
=== TestUniquePtr ===
=== TestVariant ===
testDetails
testSimple
testDuplicate
testCopy
testMove
testDestructor
testEquality
testMatching
testRvalueMatcher
TestVariant OK!
=== TestVector ===
=== TestWeakPtr ===
=== TestXorShift128PlusRNG ===

$ ./jsapi-tests
testXDR_sourceMap
TEST-PASS | testXDR_sourceMap | ok
testXDR_source
TEST-PASS | testXDR_source | ok
testXDR_bug516827
TEST-PASS | testXDR_bug516827 | ok
testXDR_bug506491
TEST-PASS | testXDR_bug506491 | ok
testWeakMap_keyDelegates
TEST-PASS | testWeakMap_keyDelegates | ok
testWeakMap_basicOperations
TEST-PASS | testWeakMap_basicOperations | ok
testWasmLEB128_invalid_decoding
TEST-PASS | testWasmLEB128_invalid_decoding | ok
testWasmLEB128_valid_decoding
TEST-PASS | testWasmLEB128_valid_decoding | ok
testWasmLEB128_encoding
TEST-PASS | testWasmLEB128_encoding | ok
testUncaughtSymbol
TEST-PASS | testUncaughtSymbol | ok
test_JS_ubi_ShortestPaths_multiple_edges_to_target
path[0]->predecessor() = 'a'
Edge name = 'x'
path[0]->predecessor() = 'a'
Edge name = 'y'
path[0]->predecessor() = 'a'
Edge name = 'z'
numPathsFound = 3
TEST-PASS | test_JS_ubi_ShortestPaths_multiple_edges_to_target | ok
test_JS_ubi_ShortestPaths_more_paths_than_max
path[0]->predecessor() = 'a'
numPathsFound = 1
TEST-PASS | test_JS_ubi_ShortestPaths_more_paths_than_max | ok
test_JS_ubi_ShortestPaths_multiple_paths
path[0]->predecessor() = 'a'
path[0]->predecessor() = 'a'
path[1]->predecessor() = 'b'
path[2]->predecessor() = 'c'
path[0]->predecessor() = 'a'
path[1]->predecessor() = 'd'
path[2]->predecessor() = 'e'
numPathsFound = 3
TEST-PASS | test_JS_ubi_ShortestPaths_multiple_paths | ok
test_JS_ubi_ShortestPaths_one_path
path[0]->predecessor() = 'a'
path[1]->predecessor() = 'c'
TEST-PASS | test_JS_ubi_ShortestPaths_one_path | ok
test_JS_ubi_ShortestPaths_no_path
TEST-PASS | test_JS_ubi_ShortestPaths_no_path | ok
test_JS_ubi_Node_scriptFilename
TEST-PASS | test_JS_ubi_Node_scriptFilename | ok
test_JS_ubi_DominatorTree
r's immediate dominator is r
Checking r's dominated set:
    Expecting r
    Expecting a
    Expecting b
    Expecting c
    Expecting d
    Expecting e
    Expecting h
    Expecting i
    Expecting k
    Found r
    Found b
    Found a
    Found d
    Found e
    Found h
    Found c
    Found i
    Found k
Done checking r's dominated set.

a's immediate dominator is r
Checking a's dominated set:
Done checking a's dominated set.

b's immediate dominator is r
Checking b's dominated set:
Done checking b's dominated set.

c's immediate dominator is r
Checking c's dominated set:
    Expecting f
    Expecting g
    Found f
    Found g
Done checking c's dominated set.

d's immediate dominator is r
Checking d's dominated set:
    Expecting l
    Found l
Done checking d's dominated set.

e's immediate dominator is r
Checking e's dominated set:
Done checking e's dominated set.

f's immediate dominator is r
Checking f's dominated set:
Done checking f's dominated set.

g's immediate dominator is r
Checking g's dominated set:
    Expecting j
    Found j
Done checking g's dominated set.

h's immediate dominator is r
Checking h's dominated set:
Done checking h's dominated set.

i's immediate dominator is r
Checking i's dominated set:
Done checking i's dominated set.

j's immediate dominator is c
Checking j's dominated set:
Done checking j's dominated set.

k's immediate dominator is r
Checking k's dominated set:
Done checking k's dominated set.

l's immediate dominator is r
Checking l's dominated set:
Done checking l's dominated set.

TEST-PASS | test_JS_ubi_DominatorTree | ok
test_ubiPostOrder
visited.length() = 8
visited[0] = 'g'
visited[1] = 'f'
visited[2] = 'e'
visited[3] = 'd'
visited[4] = 'c'
visited[5] = 'b'
visited[6] = 'a'
visited[7] = 'r'
TEST-PASS | test_ubiPostOrder | ok
test_ubiCoarseType
TEST-PASS | test_ubiCoarseType | ok
test_ubiStackFrame
TEST-PASS | test_ubiStackFrame | ok
test_ubiNodeJSObjectConstructorName
TEST-PASS | test_ubiNodeJSObjectConstructorName | ok
test_ubiNodeCompartment
TEST-PASS | test_ubiNodeCompartment | ok
test_ubiNodeZone
TEST-PASS | test_ubiNodeZone | ok
testUTF8_badSurrogate
TEST-PASS | testUTF8_badSurrogate | ok
testUTF8_bigUTF8
TEST-PASS | testUTF8_bigUTF8 | ok
testUTF8_badUTF8
TEST-PASS | testUTF8_badUTF8 | ok
testTypedArrays
TEST-PASS | testTypedArrays | ok
testToUint64Large
TEST-PASS | testToUint64Large | ok
testToUint32Large
TEST-PASS | testToUint32Large | ok
testToInt8
TEST-PASS | testToInt8 | ok
testToUint8TwiceUint8Range
TEST-PASS | testToUint8TwiceUint8Range | ok
testThreadingThreadArgCopy
TEST-PASS | testThreadingThreadArgCopy | ok
testThreadingThreadVectorMoveConstruct
TEST-PASS | testThreadingThreadVectorMoveConstruct | ok
testThreadingThreadId
TEST-PASS | testThreadingThreadId | ok
testThreadingThreadSetName
TEST-PASS | testThreadingThreadSetName | ok
testThreadingThreadDetach
TEST-PASS | testThreadingThreadDetach | ok
testThreadingThreadJoin
TEST-PASS | testThreadingThreadJoin | ok
testThreadingUnlockGuard
TEST-PASS | testThreadingUnlockGuard | ok
testThreadingLockGuard
TEST-PASS | testThreadingLockGuard | ok
testThreadingMutex
TEST-PASS | testThreadingMutex | ok
testExclusiveData
TEST-PASS | testExclusiveData | ok
testThreadingConditionVariableForTimeoutPredicate
TEST-PASS | testThreadingConditionVariableForTimeoutPredicate | ok
testThreadingConditionVariableForOkayPredicate
TEST-PASS | testThreadingConditionVariableForOkayPredicate | ok
testThreadingConditionVariableForTimeout
TEST-PASS | testThreadingConditionVariableForTimeout | ok
testThreadingConditionVariableForOkay
TEST-PASS | testThreadingConditionVariableForOkay | ok
testThreadingConditionVariableUntilTimeoutPredicate
TEST-PASS | testThreadingConditionVariableUntilTimeoutPredicate | ok
testThreadingConditionVariableUntilOkayPredicate
TEST-PASS | testThreadingConditionVariableUntilOkayPredicate | ok
testThreadingConditionVariableUntilTimeout
TEST-PASS | testThreadingConditionVariableUntilTimeout | ok
testThreadingConditionVariableUntilOkay
TEST-PASS | testThreadingConditionVariableUntilOkay | ok
testThreadingConditionVariablePredicate
TEST-PASS | testThreadingConditionVariablePredicate | ok
testThreadingConditionVariable
TEST-PASS | testThreadingConditionVariable | ok
testSymbol_GetWellKnownSymbol
TEST-PASS | testSymbol_GetWellKnownSymbol | ok
testSymbol_GetSymbolFor
TEST-PASS | testSymbol_GetSymbolFor | ok
testSymbol_New
TEST-PASS | testSymbol_New | ok
testStructuredClone_SavedFrame
Testing with principals 'IsSystem'
Testing with principals 'IsNotSystem'
Testing with principals 'testPrincipals'
Testing with principals 'nullptr principals'
TEST-PASS | testStructuredClone_SavedFrame | ok
testStructuredClone_string
TEST-PASS | testStructuredClone_string | ok
testStructuredClone_object
TEST-PASS | testStructuredClone_object | ok
testStringBuffer_finishString
TEST-PASS | testStringBuffer_finishString | ok
testBug795104
TEST-PASS | testBug795104 | ok
testSharedImmutableStringsCache
TEST-PASS | testSharedImmutableStringsCache | ok
testSetPropertyIgnoringNamedGetter_direct
TEST-PASS | testSetPropertyIgnoringNamedGetter_direct | ok
testSetProperty_InheritedGlobalSetter
TEST-PASS | testSetProperty_InheritedGlobalSetter | ok
testSetProperty_NativeGetterStubSetter
TEST-PASS | testSetProperty_NativeGetterStubSetter | ok
CloneAndExecuteScript
TEST-PASS | CloneAndExecuteScript | ok
bug438633_JS_CompileFileHandleForPrincipals
TEST-PASS | bug438633_JS_CompileFileHandleForPrincipals | ok
bug438633_JS_CompileFileHandle_empty
TEST-PASS | bug438633_JS_CompileFileHandle_empty | ok
bug438633_JS_CompileFileHandle
TEST-PASS | bug438633_JS_CompileFileHandle | ok
bug438633_JS_CompileFile_empty
TEST-PASS | bug438633_JS_CompileFile_empty | ok
bug438633_JS_CompileFile
TEST-PASS | bug438633_JS_CompileFile | ok
bug438633_JS_CompileUCScriptForPrincipals
TEST-PASS | bug438633_JS_CompileUCScriptForPrincipals | ok
bug438633_JS_CompileUCScript_empty
TEST-PASS | bug438633_JS_CompileUCScript_empty | ok
bug438633_JS_CompileUCScript
TEST-PASS | bug438633_JS_CompileUCScript | ok
bug438633_CompileScriptForPrincipals
TEST-PASS | bug438633_CompileScriptForPrincipals | ok
bug438633_CompileScript_empty
TEST-PASS | bug438633_CompileScript_empty | ok
bug438633_CompileScript
TEST-PASS | bug438633_CompileScript | ok
testScriptInfo
js/src/jsapi-tests/testScriptInfo.cpp:1011:Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead
TEST-PASS | testScriptInfo | ok
testSavedStacks_selfHostedFrames
TEST-PASS | testSavedStacks_selfHostedFrames | ok
testSavedStacks_ErrorStackV8
TEST-PASS | testSavedStacks_ErrorStackV8 | ok
testSavedStacks_ErrorStackSpiderMonkey
TEST-PASS | testSavedStacks_ErrorStackSpiderMonkey | ok
testSavedStacks_RangeBasedForLoops
TEST-PASS | testSavedStacks_RangeBasedForLoops | ok
testSavedStacks_ApiDefaultValues
TEST-PASS | testSavedStacks_ApiDefaultValues | ok
testSavedStacks_withNoStack
TEST-PASS | testSavedStacks_withNoStack | ok
testSameValue
TEST-PASS | testSameValue | ok
testResolveRecursion_InitStandardClasses
TEST-PASS | testResolveRecursion_InitStandardClasses | ok
testResolveRecursion
TEST-PASS | testResolveRecursion | ok
testGetRegExpSource
TEST-PASS | testGetRegExpSource | ok
testGetRegExpFlags
TEST-PASS | testGetRegExpFlags | ok
testObjectIsRegExp
TEST-PASS | testObjectIsRegExp | ok
testPropCache_bug505798
TEST-PASS | testPropCache_bug505798 | ok
testPromise_PromiseCatch
TEST-PASS | testPromise_PromiseCatch | ok
testPromise_PromiseThen
TEST-PASS | testPromise_PromiseThen | ok
testPromise_RejectPromise
TEST-PASS | testPromise_RejectPromise | ok
testPromise_ResolvePromise
TEST-PASS | testPromise_ResolvePromise | ok
testPromise_GetPromiseState
TEST-PASS | testPromise_GetPromiseState | ok
testPromise_NewPromise
TEST-PASS | testPromise_NewPromise | ok
testProfileStrings_worksWhenEnabledOnTheFly
TEST-PASS | testProfileStrings_worksWhenEnabledOnTheFly | ok
testProfileStrings_isCalledWhenError
TEST-PASS | testProfileStrings_isCalledWhenError | ok
testProfileStrings_isCalledWithJIT
TEST-PASS | testProfileStrings_isCalledWithJIT | ok
testProfileStrings_isCalledWithInterpreter
TEST-PASS | testProfileStrings_isCalledWithInterpreter | ok
testPrivateGCThingValue
TEST-PASS | testPrivateGCThingValue | ok
testPrintf
TEST-PASS | testPrintf | ok
test_PreserveJitCode
js/src/jsapi-tests/testPreserveJitCode.cpp:78:CHECK_EQUAL failed: expected (1u) = 1, got (countIonScripts(global)) = 0
js/src/jsapi-tests/testPreserveJitCode.cpp:22:CHECK failed: testPreserveJitCode(false, 0)
TEST-KNOWN-FAIL | test_PreserveJitCode | js/src/jsapi-tests/testPreserveJitCode.cpp:78:CHECK_EQUAL failed: expected (1u) = 1, got (countIonScripts(global)) = 0 | js/src/jsapi-tests/testPreserveJitCode.cpp:22:CHECK failed: testPreserveJitCode(false, 0)
test_GlobalPersistentRooted
TEST-PASS | test_GlobalPersistentRooted | ok
test_PersistentRootedAssign
TEST-PASS | test_PersistentRootedAssign | ok
test_PersistentRootedCopy
TEST-PASS | test_PersistentRootedCopy | ok
test_PersistentRootedNull
TEST-PASS | test_PersistentRootedNull | ok
test_PersistentRooted
TEST-PASS | test_PersistentRooted | ok
testParseJSON_reviver
TEST-PASS | testParseJSON_reviver | ok
testParseJSON_error
TEST-PASS | testParseJSON_error | ok
testParseJSON_success
TEST-PASS | testParseJSON_success | ok
testObjectEmulatingUndefined_equal
TEST-PASS | testObjectEmulatingUndefined_equal | ok
testObjectEmulatingUndefined_truthy
TEST-PASS | testObjectEmulatingUndefined_truthy | ok
testOOM
TEST-PASS | testOOM | ok
testNullRoot
TEST-PASS | testNullRoot | ok
testNewTargetInvokeConstructor
TEST-PASS | testNewTargetInvokeConstructor | ok
testNewObject_1
TEST-PASS | testNewObject_1 | ok
testMutedErrors
TEST-PASS | testMutedErrors | ok
testMappedArrayBuffer_bug945152
TEST-PASS | testMappedArrayBuffer_bug945152 | ok
test_undef_leq_null
TEST-PASS | test_undef_leq_null | ok
test_null_leq_undef
TEST-PASS | test_null_leq_undef | ok
test_nz_leq_pz
TEST-PASS | test_nz_leq_pz | ok
test_pz_leq_nz
TEST-PASS | test_pz_leq_nz | ok
test_leq_same_nums
TEST-PASS | test_leq_same_nums | ok
test_all_nleq_nan
TEST-PASS | test_all_nleq_nan | ok
test_nan_nleq_all
TEST-PASS | test_nan_nleq_all | ok
test_null_leq_null
TEST-PASS | test_null_leq_null | ok
test_undef_leq_undef
TEST-PASS | test_undef_leq_undef | ok
testLookup_bug570195
TEST-PASS | testLookup_bug570195 | ok
testLookup_bug522590
TEST-PASS | testLookup_bug522590 | ok
testJitRegisterSet_FPU_Aliases
TEST-PASS | testJitRegisterSet_FPU_Aliases | ok
testJitRegisterSet_FPU
TEST-PASS | testJitRegisterSet_FPU | ok
testJitRegisterSet_GPR
TEST-PASS | testJitRegisterSet_GPR | ok
testJitRangeAnalysis_shiftRight
TEST-PASS | testJitRangeAnalysis_shiftRight | ok
testJitRangeAnalysis_StrictCompareBeta
TEST-PASS | testJitRangeAnalysis_StrictCompareBeta | ok
testJitRangeAnalysis_MathSignBeta
TEST-PASS | testJitRangeAnalysis_MathSignBeta | ok
testJitRangeAnalysis_MathSign
TEST-PASS | testJitRangeAnalysis_MathSign | ok
testJitRValueAlloc_ConstantPool
TEST-PASS | testJitRValueAlloc_ConstantPool | ok
testJitRValueAlloc_UndefinedAndNull
TEST-PASS | testJitRValueAlloc_UndefinedAndNull | ok
testJitRValueAlloc_UntypedStack
TEST-PASS | testJitRValueAlloc_UntypedStack | ok
testJitRValueAlloc_UntypedReg
TEST-PASS | testJitRValueAlloc_UntypedReg | ok
testJitRValueAlloc_TypedStack
TEST-PASS | testJitRValueAlloc_TypedStack | ok
testJitRValueAlloc_TypedReg
TEST-PASS | testJitRValueAlloc_TypedReg | ok
testJitRValueAlloc_FloatStack
TEST-PASS | testJitRValueAlloc_FloatStack | ok
testJitRValueAlloc_FloatReg
TEST-PASS | testJitRValueAlloc_FloatReg | ok
testJitRValueAlloc_Double
TEST-PASS | testJitRValueAlloc_Double | ok
testJitGVN_PinnedPhis
TEST-PASS | testJitGVN_PinnedPhis | ok
testJitGVN_FixupOSROnlyLoopNested
TEST-PASS | testJitGVN_FixupOSROnlyLoopNested | ok
testJitGVN_FixupOSROnlyLoop
TEST-PASS | testJitGVN_FixupOSROnlyLoop | ok
testJitFoldsTo_UnsignedMod
TEST-PASS | testJitFoldsTo_UnsignedMod | ok
testJitFoldsTo_UnsignedDiv
TEST-PASS | testJitFoldsTo_UnsignedDiv | ok
testJitNotNotTest
TEST-PASS | testJitNotNotTest | ok
testJitNotTest
TEST-PASS | testJitNotTest | ok
testJitNotNotNot
TEST-PASS | testJitNotNotNot | ok
testJitNotNot
TEST-PASS | testJitNotNot | ok
testJitFoldsTo_NoDivReciprocal
TEST-PASS | testJitFoldsTo_NoDivReciprocal | ok
testJitFoldsTo_DivReciprocal
TEST-PASS | testJitFoldsTo_DivReciprocal | ok
testJitDCEinGVN_phi
TEST-PASS | testJitDCEinGVN_phi | ok
testJitDCEinGVN_ins
TEST-PASS | testJitDCEinGVN_ins | ok
testJSEvaluateScript
TEST-PASS | testJSEvaluateScript | ok
testIteratorObject
TEST-PASS | testIteratorObject | ok
testIsInsideNursery
TEST-PASS | testIsInsideNursery | ok
testIntlAvailableLocales
TEST-PASS | testIntlAvailableLocales | ok
testPinAcrossGC
TEST-PASS | testPinAcrossGC | ok
testAtomizedIsNotPinned
TEST-PASS | testAtomizedIsNotPinned | ok
testIntTypesABI
TEST-PASS | testIntTypesABI | ok
testIntString_bug515273
TEST-PASS | testIntString_bug515273 | ok
testStringToPropertyName
TEST-PASS | testStringToPropertyName | ok
testStringIsIndex
TEST-PASS | testStringIsIndex | ok
testIndexToString
TEST-PASS | testIndexToString | ok
testHashTableMovableEnum
TEST-PASS | testHashTableMovableEnum | ok
testHashSetOfMoveOnlyType
TEST-PASS | testHashSetOfMoveOnlyType | ok
testHashRekeyManualRemoval
TEST-PASS | testHashRekeyManualRemoval | ok
testHashRekeyManual
TEST-PASS | testHashRekeyManual | ok
test_GetPropertyDescriptor
TEST-PASS | test_GetPropertyDescriptor | ok
testGCWeakRef
TEST-PASS | testGCWeakRef | ok
testWeakCacheGCVector
TEST-PASS | testWeakCacheGCVector | ok
testWeakCacheMap
TEST-PASS | testWeakCacheMap | ok
testWeakCacheSet
TEST-PASS | testWeakCacheSet | ok
testGCUID
TEST-PASS | testGCUID | ok
testGCStoreBufferRemoval
TEST-PASS | testGCStoreBufferRemoval | ok
testGCOutOfMemory
TEST-PASS | testGCOutOfMemory | ok
testIncrementalRoots
TEST-PASS | testIncrementalRoots | ok
testLiveNurseryWrappeeCCW
TEST-PASS | testLiveNurseryWrappeeCCW | ok
testLiveNurseryWrapperCCW
TEST-PASS | testLiveNurseryWrapperCCW | ok
testLiveNurseryCCW
TEST-PASS | testLiveNurseryCCW | ok
testDeadNurseryCCW
TEST-PASS | testDeadNurseryCCW | ok
testTracingIncomingCCWs
*thingp         = 0x7000baa8080
*expectedThingp = 0x7000baa8080
kind         = 0
expectedKind = 0
TEST-PASS | testTracingIncomingCCWs | ok
testGCSliceCallback
TEST-PASS | testGCSliceCallback | ok
testUnbarrieredEquality
TEST-PASS | testUnbarrieredEquality | ok
testGCHeapPostBarriers
TEST-PASS | testGCHeapPostBarriers | ok
testGCGrayMarking
TEST-PASS | testGCGrayMarking | ok
testGCFinalizeCallback
TEST-PASS | testGCFinalizeCallback | ok
testGCHandleVector
TEST-PASS | testGCHandleVector | ok
testTraceableFifo
TEST-PASS | testTraceableFifo | ok
testGCRootedVector
TEST-PASS | testGCRootedVector | ok
testGCHandleHashMap
TEST-PASS | testGCHandleHashMap | ok
testGCRootedHashMap
TEST-PASS | testGCRootedHashMap | ok
testGCPersistentRootedTraceableCannotOutliveRuntime
TEST-PASS | testGCPersistentRootedTraceableCannotOutliveRuntime | ok
testGCPersistentRootedOutlivesRuntime
TEST-PASS | testGCPersistentRootedOutlivesRuntime | ok
testGCRootedStaticStructInternalStackStorageAugmented
TEST-PASS | testGCRootedStaticStructInternalStackStorageAugmented | ok
testGCSuppressions
TEST-PASS | testGCSuppressions | ok
testGCExactRooting
TEST-PASS | testGCExactRooting | ok
testGCChunkPool
TEST-PASS | testGCChunkPool | ok
testGCCellPtr
TEST-PASS | testGCCellPtr | ok
testGCAllocator
TEST-PASS | testGCAllocator | ok
testFunctionProperties
TEST-PASS | testFunctionProperties | ok
test_functionBinding
TEST-PASS | test_functionBinding | ok
testRedefineGlobalEval
TEST-PASS | testRedefineGlobalEval | ok
testForwardSetProperty
TEST-PASS | testForwardSetProperty | ok
testForceLexicalInitialization
TEST-PASS | testForceLexicalInitialization | ok
testForOfIterator_bug515273_part2
TEST-PASS | testForOfIterator_bug515273_part2 | ok
testForOfIterator_bug515273_part1
TEST-PASS | testForOfIterator_bug515273_part1 | ok
testForOfIterator_basicNonIterable
TEST-PASS | testForOfIterator_basicNonIterable | ok
testFindSCCsStackLimit
TEST-PASS | testFindSCCsStackLimit | ok
testFindSCCs
TEST-PASS | testFindSCCs | ok
testExternalStrings
TEST-PASS | testExternalStrings | ok
testExternalArrayBuffer
js/src/jsapi-tests/testExternalArrayBuffer.cpp:43:CHECK failed: test_data == data
js/src/jsapi-tests/testExternalArrayBuffer.cpp:23:CHECK failed: VerifyObject(obj, length)
TEST-UNEXPECTED-FAIL | testExternalArrayBuffer | js/src/jsapi-tests/testExternalArrayBuffer.cpp:43:CHECK failed: test_data == data | js/src/jsapi-tests/testExternalArrayBuffer.cpp:23:CHECK failed: VerifyObject(obj, length)
testException_bug860435
TEST-PASS | testException_bug860435 | ok
testErrorCopying_columnCopied
TEST-PASS | testErrorCopying_columnCopied | ok
testDifferentNewTargetInvokeConstructor
TEST-PASS | testDifferentNewTargetInvokeConstructor | ok
test_DeflateStringToUTF8Buffer
TEST-PASS | test_DeflateStringToUTF8Buffer | ok
testDefinePropertyIgnoredAttributes
TEST-PASS | testDefinePropertyIgnoredAttributes | ok
testDefineProperty_bug564344
TEST-PASS | testDefineProperty_bug564344 | ok
testDefineGetterSetterNonEnumerable
TEST-PASS | testDefineGetterSetterNonEnumerable | ok
testDeepFreeze_loop
TEST-PASS | testDeepFreeze_loop | ok
testDeepFreeze_deep
TEST-PASS | testDeepFreeze_deep | ok
testDeepFreeze_bug535703
TEST-PASS | testDeepFreeze_bug535703 | ok
testDebugger_newScriptHook
TEST-PASS | testDebugger_newScriptHook | ok
testDateToLocaleString
TEST-PASS | testDateToLocaleString | ok
test_cloneScriptWithPrincipals
TEST-PASS | test_cloneScriptWithPrincipals | ok
test_cloneScript
TEST-PASS | test_cloneScript | ok
testClassGetter_isCalled
TEST-PASS | testClassGetter_isCalled | ok
testChromeBuffer
TEST-PASS | testChromeBuffer | ok
test_CallNonGenericMethodOnProxy
TEST-PASS | test_CallNonGenericMethodOnProxy | ok
testCallArgs_isConstructing_constructor
TEST-PASS | testCallArgs_isConstructing_constructor | ok
testCallArgs_isConstructing_native
TEST-PASS | testCallArgs_isConstructing_native | ok
testBug604087
TEST-PASS | testBug604087 | ok
testBoundFunction
TEST-PASS | testBoundFunction | ok
testArrayBufferView_type
TEST-PASS | testArrayBufferView_type | ok
testArrayBuffer_externalize
TEST-PASS | testArrayBuffer_externalize | ok
testArrayBuffer_bug720949_viewList
TEST-PASS | testArrayBuffer_bug720949_viewList | ok
testArrayBuffer_bug720949_steal
TEST-PASS | testArrayBuffer_bug720949_steal | ok
testArgumentsObject
TEST-PASS | testArgumentsObject | ok
testAddPropertyHook
TEST-PASS | testAddPropertyHook | ok
selfTest_NaNsAreSame
TEST-PASS | selfTest_NaNsAreSame | ok
testAssemblerBuffer_ARM64
TEST-PASS | testAssemblerBuffer_ARM64 | ok
testAssemblerBuffer_AssemblerBufferWithConstantPools_ShortBranch
TEST-PASS | testAssemblerBuffer_AssemblerBufferWithConstantPools_ShortBranch | ok
testAssemblerBuffer_AssemblerBufferWithConstantPools
TEST-PASS | testAssemblerBuffer_AssemblerBufferWithConstantPools | ok
testAssemblerBuffer_BranchDeadlineSet
TEST-PASS | testAssemblerBuffer_BranchDeadlineSet | ok
testAssemblerBuffer_AssemblerBuffer
TEST-PASS | testAssemblerBuffer_AssemblerBuffer | ok
testAssemblerBuffer_BufferOffset
TEST-PASS | testAssemblerBuffer_BufferOffset | ok

1 unexpected failure.

Comment hidden (mozreview-request)

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155478/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155478/diff/2-3/

Jan Beich

Assignee

Comment 5

•

7 years ago

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1370696 regression
[User impact if declined]: Broken build on FreeBSD aarch64 and armv6 unless --disable-ion is passed
[Is this code covered by automated tests?]: NPOTB but otherwise probably yes.
[Has the fix been verified in Nightly?]: I don't have hardware, so verified aarch64 and armv6 via qemu-user-static using JS standalone on FF56 and FF55.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only a syntax typo can break Tier1 build.
[String changes made/needed]: None

Attachment #8884597 - Flags: approval-mozilla-beta?

Julien Cristau [:jcristau]

Updated

•

7 years ago

status-firefox55: affected → fix-optional

Julien Cristau [:jcristau]

Updated

•

7 years ago

Assignee: nobody → jbeich

Jan Beich

Assignee

Updated

•

7 years ago

Attachment #8884597 - Flags: review?(luke)

Jan Beich

Assignee

Comment 6

•

7 years ago

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

Added :luke as an alternative reviewer who r+'d a similar patch in bug 1359142.

Benjamin Bouvier [:bbouvier] (inactive)

Comment 7

•

7 years ago

mozreview-review

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

https://reviewboard.mozilla.org/r/155478/#review161680

Looks good to me, sorry about the slow review time.

Attachment #8884597 - Flags: review?(bbouvier) → review+

Benjamin Bouvier [:bbouvier] (inactive)

Updated

•

7 years ago

Attachment #8884597 - Flags: review?(luke)

Pulsebot

Comment 8

•

7 years ago

Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e12285e2131
Unbreak BSDs build on ARM* after bug 1370696. r=bbouvier

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 9

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/1e12285e2131

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox56: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla56

Julien Cristau [:jcristau]

Comment 10

•

7 years ago

Comment on attachment 8884597 [details]
Bug 1379430 - Unbreak BSDs build on ARM* after bug 1370696.

wasm build fix for bsd, beta55+

Attachment #8884597 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Carsten Book [:Tomcat]

Comment 11

•

7 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/2ffb98c6fafa

status-firefox55: fix-optional → fixed

Andrei Vaida [:avaida]

Comment 12

•

7 years ago

(In reply to Jan Beich from comment #5)
> [Is this code covered by automated tests?]: NPOTB but otherwise probably yes.
> [Has the fix been verified in Nightly?]: I don't have hardware, so verified
> aarch64 and armv6 via qemu-user-static using JS standalone on FF56 and FF55.
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Jan's assessment on manual testing needs.

Flags: in-moztrap-